DevTools: [SSP] implement "add rule to end" of arbitrary style sheet.

DevTools: [SSP] implement "add rule to end" of arbitrary style sheet.

The patch adds long click behavior to the "add new rule" button, which
opens a list of user stylesheets where you can add a new rule.

BUG=402461
Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=181552

[lushnikov, 2014-09-01 16:56:51]

lushnikov@chromium.org changed reviewers:
+ pfeldman@chromium.org, vsevik@chromium.org

[lushnikov, 2014-09-01 16:56:52]

PTAL

[lushnikov, 2014-09-02 08:54:31]

On 2014/09/01 16:56:52, lushnikov wrote:
> PTAL

The video demo could be found in the bug

[lushnikov, 2014-09-02 11:11:10]

On 2014/09/02 08:54:31, lushnikov wrote:
> On 2014/09/01 16:56:52, lushnikov wrote:
> > PTAL
> 
> The video demo could be found in the bug

@vsevik, this looks gorgeous, isn't it? Do we wait for @pfeldman UI
approval/critic?

[vsevik, 2014-09-05 06:39:24]

lgtm

https://codereview.chromium.org/529553002/diff/100001/Source/devtools/front_e...
File Source/devtools/front_end/elements/StylesSidebarPane.js (right):

https://codereview.chromium.org/529553002/diff/100001/Source/devtools/front_e...
Source/devtools/front_end/elements/StylesSidebarPane.js:1639: return
this._linkifyRuleLocation(rule.styleSheetId, ruleLocation);
Why did you remove rule.resourceURL() check?

https://codereview.chromium.org/529553002/diff/100001/Source/devtools/front_e...
Source/devtools/front_end/elements/StylesSidebarPane.js:1659: function
linkifyUncopyable(url, line)
I know it was like that before, but user agent stylesheet should actually be
uncopyable as well.

[lushnikov, 2014-09-05 08:17:52]

https://codereview.chromium.org/529553002/diff/100001/Source/devtools/front_e...
File Source/devtools/front_end/elements/StylesSidebarPane.js (right):

https://codereview.chromium.org/529553002/diff/100001/Source/devtools/front_e...
Source/devtools/front_end/elements/StylesSidebarPane.js:1639: return
this._linkifyRuleLocation(rule.styleSheetId, ruleLocation);
On 2014/09/05 06:39:24, vsevik wrote:
> Why did you remove rule.resourceURL() check?

Because having resourceURL of the rule is equal styleSheet sourceURL, which, in
turn, happens to exist iff there's a rule styleSheetId

[lushnikov, 2014-09-05 08:18:03]

The CQ bit was checked by lushnikov@chromium.org

[commit-bot: I haz the power, 2014-09-05 08:18:45]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/lushnikov@chromium.org/529553002/100001

[lushnikov, 2014-09-05 08:18:46]

https://codereview.chromium.org/529553002/diff/100001/Source/devtools/front_e...
File Source/devtools/front_end/elements/StylesSidebarPane.js (right):

https://codereview.chromium.org/529553002/diff/100001/Source/devtools/front_e...
Source/devtools/front_end/elements/StylesSidebarPane.js:1659: function
linkifyUncopyable(url, line)
On 2014/09/05 06:39:24, vsevik wrote:
> I know it was like that before, but user agent stylesheet should actually be
> uncopyable as well.

Lets have this in a follow-up

[commit-bot: I haz the power, 2014-09-05 09:20:02]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-09-05 09:20:04]

Try jobs failed on following builders:
  linux_blink_rel on tryserver.blink
(http://build.chromium.org/p/tryserver.blink/builders/linux_blink_rel/builds/2...)

[lushnikov, 2014-09-08 09:36:58]

The CQ bit was checked by lushnikov@chromium.org

[commit-bot: I haz the power, 2014-09-08 09:37:42]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/lushnikov@chromium.org/529553002/120001

[commit-bot: I haz the power, 2014-09-08 10:44:11]

Committed patchset #7 (id:120001) as 181552