Rename DriveProvider to ExternalProvider.

Rename DriveProvider to ExternalProvider.

Since metadata properties fetched by DriveProvider in MetadataCache are going
to work for FSP also, it is renamed to ExternalProvider (since Drive and FSP
are both on the external backend).

TEST=Tested manually that Files app and the gallery work.
BUG=408017
Committed: https://crrev.com/4189453237c2ef570d07e132c72b171664a19e51
Cr-Commit-Position: refs/heads/master@{#293679}

[mtomasz, 2014-09-03 09:39:08]

mtomasz@chromium.org changed reviewers:
+ hirono@chromium.org, yoshiki@chromium.org

[mtomasz, 2014-09-03 09:39:41]

@yoshiki: PTAL especially at MetadataCache.
@hirono: PTAL especially at Gallery.

Thanks.

[hirono, 2014-09-04 03:45:02]

https://codereview.chromium.org/529413002/diff/1/ui/file_manager/gallery/js/g...
File ui/file_manager/gallery/js/gallery_item.js (right):

https://codereview.chromium.org/529413002/diff/1/ui/file_manager/gallery/js/g...
ui/file_manager/gallery/js/gallery_item.js:15: * @param {boolean} readonly
Whether the entry is located at readonly directory
If the item takes EntryLocation, we don't need to pass readonly flag.

https://codereview.chromium.org/529413002/diff/1/ui/file_manager/gallery/js/g...
ui/file_manager/gallery/js/gallery_item.js:151:
Gallery.Item.prototype.isShareable = function() {
Is it used?

[yoshiki, 2014-09-04 05:42:04]

metadata lgtm

[mtomasz, 2014-09-05 02:50:14]

On 2014/09/04 05:42:04, yoshiki wrote:
> metadata lgtm

@hirono: I reworked the Gallery.Item, but by just adding VolumeManager reference
to it. If we don't want it, the entire code has to be very significantly
reworked. Gallery.Item just has a lot of logic, and because of that requires big
classes.

I could pass a VolumeManager to Gallery.Item.saveToFile, but I still have to add
it to GalleryDataModel. I can't pass VolumeManager to GalleryDataModel.saveItem,
because the called (SlideMode) doesn't have a VolumeManager.

I tied to move the entire saveToFile() code to GalleryDataModel, but that's
causes that the logic is split among files. (Eg. we're renaming in Gallery.Item,
but saving in GalleryDataModel). I don't think if that's the correct solution.

I think the long term goal would be reworking the code by eg. making
Gallery.Item immutable, and if we save an image, then creating a new one with
replacing the old one. We could have static methods like
Gallery.Item.CreateFromCanvas(canvas, originalGalleryItem) or sth like that to
keep all the logic in one file. However, that's a lot of refactoring, and it
would take a significant time, while my plate is really full at this moment...

[mtomasz, 2014-09-08 01:28:14]

On 2014/09/05 02:50:14, mtomasz wrote:
> On 2014/09/04 05:42:04, yoshiki wrote:
> > metadata lgtm
> 
> @hirono: I reworked the Gallery.Item, but by just adding VolumeManager
reference
> to it. If we don't want it, the entire code has to be very significantly
> reworked. Gallery.Item just has a lot of logic, and because of that requires
big
> classes.
> 
> I could pass a VolumeManager to Gallery.Item.saveToFile, but I still have to
add
> it to GalleryDataModel. I can't pass VolumeManager to
GalleryDataModel.saveItem,
> because the called (SlideMode) doesn't have a VolumeManager.
> 
> I tied to move the entire saveToFile() code to GalleryDataModel, but that's
> causes that the logic is split among files. (Eg. we're renaming in
Gallery.Item,
> but saving in GalleryDataModel). I don't think if that's the correct solution.
> 
> I think the long term goal would be reworking the code by eg. making
> Gallery.Item immutable, and if we save an image, then creating a new one with
> replacing the old one. We could have static methods like
> Gallery.Item.CreateFromCanvas(canvas, originalGalleryItem) or sth like that to
> keep all the logic in one file. However, that's a lot of refactoring, and it
> would take a significant time, while my plate is really full at this moment...

@hirono: Per our offline discussion, I just moved VolumeManager from
Gallery.Item to SlideMode, and pass it to GalleryDataItem.saveItem and then
Gallery.Item.saveToFile. PTAL. Thanks.

[hirono, 2014-09-08 03:35:57]

lgtm, thanks!

[mtomasz, 2014-09-08 03:36:54]

The CQ bit was checked by mtomasz@chromium.org

[mtomasz, 2014-09-08 03:36:58]

On 2014/09/08 03:35:57, hirono wrote:
> lgtm, thanks!

thanks!

[commit-bot: I haz the power, 2014-09-08 03:37:10]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/mtomasz@chromium.org/529413002/40001

[commit-bot: I haz the power, 2014-09-08 06:58:13]

Committed patchset #3 (id:40001) as 689776c0db3f2dabd9a69cf79edcb0cd49d4dbea

[commit-bot: I haz the power, 2014-09-10 03:44:49]

Patchset 3 (id:??) landed as
https://crrev.com/4189453237c2ef570d07e132c72b171664a19e51
Cr-Commit-Position: refs/heads/master@{#293679}