Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(387)

Issue 529403002: Layout Tests should support '*.test' URLs. (Closed)

Created:
6 years, 3 months ago by Mike West
Modified:
6 years, 3 months ago
CC:
chromium-reviews, darin-cc_chromium.org, jam, jochen+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Layout Tests should support '*.test' URLs. We need, for example, to test that ServiceWorkers can't be registered on unauthenticated origins[1]. This patch allows '*.test' as a valid URL for tests, and teaches content shell how to resolve them if (and only if) the '--dump-render-tree' flag is set. '.test' is a reserved gTLD[3], and is also used by the W3C's Web Platform Tests[3]; it seems like the best choice of suffix for layout tests. [1]: http://w3c.github.io/webappsec/specs/mixedcontent/#authenticated-origin [2]: http://newgtlds.icann.org/applicants/agb [3]: https://github.com/w3c/web-platform-tests#running-the-tests BUG=410190 Committed: https://crrev.com/2fe091b135c7f1c24c7e349ed2b40a887c561cbc Cr-Commit-Position: refs/heads/master@{#293106}

Patch Set 1 #

Patch Set 2 : content_shell #

Unified diffs Side-by-side diffs Delta from patch set Stats (+9 lines, -1 line) Patch
M content/shell/app/shell_main_delegate.cc View 1 1 chunk +3 lines, -0 lines 0 comments Download
M content/shell/renderer/test_runner/web_test_proxy.cc View 1 3 chunks +6 lines, -1 line 0 comments Download

Messages

Total messages: 9 (2 generated)
Mike West
WDYT?
6 years, 3 months ago (2014-09-03 07:51:55 UTC) #2
jochen (gone - plz use gerrit)
can you add the host resolver rule command line flag here: https://code.google.com/p/chromium/codesearch#chromium/src/content/shell/app/shell_main_delegate.cc&l=138
6 years, 3 months ago (2014-09-03 07:59:55 UTC) #3
Mike West
Done. Changed from '*.example' to '*.test', as that matches what the W3C is doing with ...
6 years, 3 months ago (2014-09-03 08:17:55 UTC) #4
jochen (gone - plz use gerrit)
lgtm
6 years, 3 months ago (2014-09-03 08:24:09 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/mkwst@chromium.org/529403002/20001
6 years, 3 months ago (2014-09-03 08:31:08 UTC) #7
commit-bot: I haz the power
Committed patchset #2 (id:20001) as acd5ec9fa4883c1602843137863d545adae8914a
6 years, 3 months ago (2014-09-03 09:36:42 UTC) #8
commit-bot: I haz the power
6 years, 3 months ago (2014-09-10 03:24:43 UTC) #9
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/2fe091b135c7f1c24c7e349ed2b40a887c561cbc
Cr-Commit-Position: refs/heads/master@{#293106}

Powered by Google App Engine
This is Rietveld 408576698