Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(143)

Unified Diff: tools/push-to-trunk/common_includes.py

Issue 529343003: Add more output when roll scripts are retrying. (Closed) Base URL: https://v8.googlecode.com/svn/branches/bleeding_edge
Patch Set: Created 6 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: tools/push-to-trunk/common_includes.py
diff --git a/tools/push-to-trunk/common_includes.py b/tools/push-to-trunk/common_includes.py
index 7770ce0762cffae84833a2499401d99724d29239..a92998596bc8b946c03e86ea283ae10cac92dc0e 100644
--- a/tools/push-to-trunk/common_includes.py
+++ b/tools/push-to-trunk/common_includes.py
@@ -318,13 +318,14 @@ class Step(GitRecipesMixin):
got_exception = False
try:
result = cb()
- except NoRetryException, e:
+ except NoRetryException as e:
raise e
- except Exception:
- got_exception = True
+ except Exception as e:
+ got_exception = e
if got_exception or retry_on(result):
if not wait_plan: # pragma: no cover
- raise Exception("Retried too often. Giving up.")
+ raise Exception("Retried too often. Giving up. Reason: %s" %
+ str(got_exception))
wait_time = wait_plan.pop()
print "Waiting for %f seconds." % wait_time
self._side_effect_handler.Sleep(wait_time)
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698