Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(121)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 529203002: BrowserPlugin: Remove dependency upon ViewHostMsg_UpdateRect (Closed)

Created:
6 years, 3 months ago by Fady Samuel
Modified:
6 years, 3 months ago
Reviewers:
kenrb, lazyboy, nasko
CC:
chromium-reviews, darin-cc_chromium.org, nasko+codewatch_chromium.org, jam, creis+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

BrowserPlugin: Remove dependency upon ViewHostMsg_UpdateRect BUG=410029, 273089 Committed: https://crrev.com/04a6f5f651663d10a9ebf799cd90fa627e12b251 Cr-Commit-Position: refs/heads/master@{#293362}

Patch Set 1 #

Patch Set 2 : Fixed broken tests in debug. #

Patch Set 3 : cleanup #

Patch Set 4 : Rebased #

Patch Set 5 : Removed unnecessary browsertest (there's a webview resize test) and IPC #

Unified diffs Side-by-side diffs Delta from patch set Stats (+78 lines, -210 lines) Patch
M content/browser/browser_plugin/browser_plugin_guest.h View 1 4 chunks +12 lines, -4 lines 0 comments Download
M content/browser/browser_plugin/browser_plugin_guest.cc View 1 5 chunks +54 lines, -30 lines 0 comments Download
M content/browser/frame_host/render_widget_host_view_guest.cc View 1 2 chunks +4 lines, -35 lines 0 comments Download
M content/common/browser_plugin/browser_plugin_messages.h View 1 2 3 4 4 chunks +1 line, -21 lines 0 comments Download
M content/renderer/browser_plugin/browser_plugin.h View 1 2 chunks +0 lines, -3 lines 0 comments Download
M content/renderer/browser_plugin/browser_plugin.cc View 1 2 10 chunks +7 lines, -44 lines 0 comments Download
M content/renderer/browser_plugin/browser_plugin_browsertest.cc View 1 2 3 4 1 chunk +0 lines, -73 lines 0 comments Download

Messages

Total messages: 43 (22 generated)
Fady Samuel
Hitting two birds with one stone! Progressing towards removing ViewHostMsg_UpdateRect (yay!) and one step towards ...
6 years, 3 months ago (2014-09-02 21:44:52 UTC) #2
lazyboy
lgtm
6 years, 3 months ago (2014-09-02 21:57:43 UTC) #3
Fady Samuel
+kenrb@: Could you please review the RenderWidgetHostViewGuest change? Thanks!
6 years, 3 months ago (2014-09-02 22:03:04 UTC) #5
kenrb
RWHVG lgtm, though I am not an owner of that file so you will still ...
6 years, 3 months ago (2014-09-03 13:51:57 UTC) #6
Fady Samuel
nasko@ for render_widget_host_view_guest OWNER review.
6 years, 3 months ago (2014-09-03 18:48:55 UTC) #8
nasko
Rubberstamp LGTM, based on kenrb@'s review.
6 years, 3 months ago (2014-09-03 18:56:05 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/fsamuel@chromium.org/529203002/60001
6 years, 3 months ago (2014-09-03 23:23:28 UTC) #15
commit-bot: I haz the power
Try jobs failed on following builders: android_clang_dbg_recipe on tryserver.chromium.linux (http://build.chromium.org/p/tryserver.chromium.linux/builders/android_clang_dbg_recipe/builds/1907)
6 years, 3 months ago (2014-09-04 02:06:45 UTC) #17
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/fsamuel@chromium.org/529203002/60001
6 years, 3 months ago (2014-09-04 02:09:20 UTC) #19
commit-bot: I haz the power
Try jobs failed on following builders: android_clang_dbg_recipe on tryserver.chromium.linux (http://build.chromium.org/p/tryserver.chromium.linux/builders/android_clang_dbg_recipe/builds/1947)
6 years, 3 months ago (2014-09-04 03:15:11 UTC) #21
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/fsamuel@chromium.org/529203002/80001
6 years, 3 months ago (2014-09-04 06:42:08 UTC) #23
commit-bot: I haz the power
Try jobs failed on following builders: android_clang_dbg_recipe on tryserver.chromium.linux (http://build.chromium.org/p/tryserver.chromium.linux/builders/android_clang_dbg_recipe/builds/2051)
6 years, 3 months ago (2014-09-04 07:36:51 UTC) #25
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/fsamuel@chromium.org/529203002/80001
6 years, 3 months ago (2014-09-04 07:43:59 UTC) #27
commit-bot: I haz the power
Try jobs failed on following builders: android_clang_dbg_recipe on tryserver.chromium.linux (http://build.chromium.org/p/tryserver.chromium.linux/builders/android_clang_dbg_recipe/builds/2072)
6 years, 3 months ago (2014-09-04 08:32:15 UTC) #29
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/fsamuel@chromium.org/529203002/80001
6 years, 3 months ago (2014-09-04 11:47:40 UTC) #31
commit-bot: I haz the power
Try jobs failed on following builders: win_gpu_triggered_tests on tryserver.chromium.gpu (http://build.chromium.org/p/tryserver.chromium.gpu/builders/win_gpu_triggered_tests/builds/47821)
6 years, 3 months ago (2014-09-04 20:19:19 UTC) #33
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/fsamuel@chromium.org/529203002/80001
6 years, 3 months ago (2014-09-04 20:27:27 UTC) #37
commit-bot: I haz the power
Try jobs failed on following builders: win_gpu_triggered_tests on tryserver.chromium.gpu (http://build.chromium.org/p/tryserver.chromium.gpu/builders/win_gpu_triggered_tests/builds/47821)
6 years, 3 months ago (2014-09-04 21:21:18 UTC) #39
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/fsamuel@chromium.org/529203002/80001
6 years, 3 months ago (2014-09-04 22:40:26 UTC) #41
commit-bot: I haz the power
Committed patchset #5 (id:80001) as 86ef57587561ffb4286bc027c07d1ec2e6092bf6
6 years, 3 months ago (2014-09-04 22:43:25 UTC) #42
commit-bot: I haz the power
6 years, 3 months ago (2014-09-10 03:33:29 UTC) #43
Message was sent while issue was closed. 
Patchset 5 (id:??) landed as
https://crrev.com/04a6f5f651663d10a9ebf799cd90fa627e12b251
Cr-Commit-Position: refs/heads/master@{#293362}

Powered by Google App Engine
This is Rietveld 408576698