Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(812)

Issue 529183002: Fix crash with forcing variations when the trial exists. (Closed)

Created:
6 years, 3 months ago by Alexei Svitkine (slow)
Modified:
6 years, 3 months ago
Reviewers:
jwd
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Fix crash with forcing variations when the trial exists. This can happen, for example, when a user used the --force-fieldtrials= command-line to set a different group than what they have selected from chrome://flags. Includes a test. BUG=409976 Committed: https://crrev.com/2955e423a8d8c0c25af89585ff21394fc77ccb9e Cr-Commit-Position: refs/heads/master@{#293173}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+31 lines, -0 lines) Patch
M components/variations/variations_seed_processor.cc View 1 chunk +7 lines, -0 lines 0 comments Download
M components/variations/variations_seed_processor_unittest.cc View 1 chunk +24 lines, -0 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
Alexei Svitkine (slow)
6 years, 3 months ago (2014-09-02 21:42:02 UTC) #2
jwd
lgtm
6 years, 3 months ago (2014-09-03 14:31:58 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/asvitkine@chromium.org/529183002/1
6 years, 3 months ago (2014-09-03 14:36:40 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1) as 2c5978f930fe9159ab8df1588fcfa8f37fef5e98
6 years, 3 months ago (2014-09-03 18:16:50 UTC) #6
commit-bot: I haz the power
6 years, 3 months ago (2014-09-10 03:26:57 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/2955e423a8d8c0c25af89585ff21394fc77ccb9e
Cr-Commit-Position: refs/heads/master@{#293173}

Powered by Google App Engine
This is Rietveld 408576698