Issue 529163002: mojo: Fix the key code for EXECUTE.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 529163002: mojo: Fix the key code for EXECUTE. (Closed)

Created:
6 years, 3 months ago by Elliot Glaysher

Modified:
6 years, 3 months ago

Reviewers:
kpschoedel, sky

CC:
chromium-reviews, qsr+mojo_chromium.org, viettrungluu+watch_chromium.org, yzshen+watch_chromium.org, abarth-chromium, Aaron Boodman, darin (slow to review), ben+mojo_chromium.org

Base URL:
https://chromium.googlesource.com/chromium/src.git@master

Project:
chromium

Visibility:
Public.

More Reviews

Description

mojo: Fix the key code for EXECUTE. BUG=none Committed: https://crrev.com/27b10ccf52dc11e0cec40708924d1923cdcce907 Cr-Commit-Position: refs/heads/master@{#293057}

Patch Set 1 #

Created: 6 years, 3 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+1 line, -1 line)			Patch
	M	mojo/services/public/interfaces/input_events/input_key_codes.mojom	View		1 chunk	+1 line, -1 line	0 comments	Download

Messages

Total messages: 7 (2 generated)

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages

Elliot Glaysher

sky: trivial review here kpschoedel: fyi, and thanks for catching this.

6 years, 3 months ago (2014-09-02 21:24:43 UTC) #2

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/erg@chromium.org/529163002/1

6 years, 3 months ago (2014-09-03 00:03:22 UTC) #5

commit-bot: I haz the power

Committed patchset #1 (id:1) as d7a3ce4433e2b436025f4d6d9846a6910d44bb09

6 years, 3 months ago (2014-09-03 02:38:19 UTC) #6

commit-bot: I haz the power

6 years, 3 months ago (2014-09-10 03:23:06 UTC) #7

Message was sent while issue was closed.

Patchset 1 (id:??) landed as
https://crrev.com/27b10ccf52dc11e0cec40708924d1923cdcce907
Cr-Commit-Position: refs/heads/master@{#293057}

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages