Do not use NSAnimation to drive scrollbar animations.

Source/platform/mac/ScrollAnimatorMac.mm

 /*
  * Copyright (C) 2010, 2011 Apple Inc. All rights reserved.
  *
  * Redistribution and use in source and binary forms, with or without
  * modification, are permitted provided that the following conditions
  * are met:
  * 1. Redistributions of source code must retain the above copyright
  *    notice, this list of conditions and the following disclaimer.
  * 2. Redistributions in binary form must reproduce the above copyright
  *    notice, this list of conditions and the following disclaimer in the
@@ skipping 11 matching lines @@
  * ARISING IN ANY WAY OUT OF THE USE OF THIS SOFTWARE, EVEN IF ADVISED OF
  * THE POSSIBILITY OF SUCH DAMAGE.
  */
 
 #include "config.h"
 
 #include "platform/mac/ScrollAnimatorMac.h"
 
 #include "platform/PlatformGestureEvent.h"
 #include "platform/PlatformWheelEvent.h"
+#include "platform/Timer.h"
+#include "platform/animation/TimingFunction.h"
 #include "platform/geometry/FloatRect.h"
 #include "platform/geometry/IntRect.h"
 #include "platform/mac/BlockExceptions.h"
 #include "platform/mac/NSScrollerImpDetails.h"
 #include "platform/scroll/ScrollView.h"
 #include "platform/scroll/ScrollableArea.h"
 #include "platform/scroll/ScrollbarTheme.h"
 #include "platform/scroll/ScrollbarThemeMacCommon.h"
 #include "platform/scroll/ScrollbarThemeMacOverlayAPI.h"
 #include "wtf/MainThread.h"
@@ skipping 243 matching lines @@
 
 @end
 
 enum FeatureToAnimate {
     ThumbAlpha,
     TrackAlpha,
     UIStateTransition,
     ExpansionTransition
 };
 
-@interface WebScrollbarPartAnimation : NSAnimation
-{
+@class WebScrollbarPartAnimation;
+
+namespace blink {
+
+// This class is used to drive the animation timer for WebScrollbarPartAnimation
+// objects. This is used instead of NSAnimation because CoreAnimation
+// establishes connections to the WindowServer, which should not be done in a
+// sandboxed renderer process.
+class WebScrollbarPartAnimationTimer {
+public:
+    WebScrollbarPartAnimationTimer(WebScrollbarPartAnimation* animation,
+                                   CFTimeInterval duration)
+        : m_timer(this, &WebScrollbarPartAnimationTimer::timerFired)
+        , m_startTime(0.0)
+        , m_duration(duration)
+        , m_animation(animation)
+        , m_timingFunction(CubicBezierTimingFunction::preset(CubicBezierTimingFunction::EaseInOut))
+    {
+    }
+
+    ~WebScrollbarPartAnimationTimer() {}
+
+    void start()
+    {
+        m_startTime = CACurrentMediaTime();

[Ken Russell (switch to Gerrit), 2014/09/03 23:06:48]

Would it be possible to use existing APIs like WTF::currentTime() for this? Or
is it not accurate enough?

[Robert Sesek, 2014/09/03 23:25:30]

Yes, though I bumped the framerate. This doesn't require terribly high accuracy.

+        // Set the framerate of the animation. NSAnimation uses a default
+        // framerate of 60 Hz. This was determined to be sufficient by
+        // visual inspection.
+        m_timer.startRepeating(1.0 / 35.0, FROM_HERE);
+    }
+
+    void stop()
+    {
+        m_timer.stop();
+        [m_animation setCurrentProgress:1];
+    }
+
+    void setDuration(CFTimeInterval duration)
+    {
+        m_duration = duration;
+    }
+
+private:
+    void timerFired(Timer<WebScrollbarPartAnimationTimer>*)
+    {
+        CFTimeInterval currentTime = CACurrentMediaTime();
+        CFTimeInterval delta = currentTime - m_startTime;
+
+        if (delta >= m_duration) {
+            stop();
+            return;
+        }
+
+        double fraction = delta / m_duration;
+        double progress = m_timingFunction->evaluate(fraction, 0.001);
+        [m_animation setCurrentProgress:progress];
+    }
+
+    Timer<WebScrollbarPartAnimationTimer> m_timer;
+    CFTimeInterval m_startTime;
+    CFTimeInterval m_duration;
+    WebScrollbarPartAnimation* m_animation;

[Ken Russell (switch to Gerrit), 2014/09/03 23:06:49]

Please document that this is a weak pointer.

[Robert Sesek, 2014/09/03 23:25:30]

Done.

+    CubicBezierTimingFunction* m_timingFunction;

[Ken Russell (switch to Gerrit), 2014/09/03 23:06:48]

Should be RefPtr<CubicBezierTimingFunction>. (See other uses of
CubicBezierTimingFunction::preset.)

[Robert Sesek, 2014/09/03 23:25:30]

Wow, thanks. I assumed that the STATIC_LOCAL thing meant it was just leaked.

[Ken Russell (switch to Gerrit), 2014/09/04 00:56:05]

I think your code was technically correct before, FWIW, because it didn't touch
the reference counts at all -- but it's better to follow the convention.

+};
+
+}  // namespace blink
+
+@interface WebScrollbarPartAnimation : NSObject {
     Scrollbar* _scrollbar;
+    OwnPtr<WebScrollbarPartAnimationTimer> _timer;
     RetainPtr<ScrollbarPainter> _scrollbarPainter;
     FeatureToAnimate _featureToAnimate;
     CGFloat _startValue;
     CGFloat _endValue;
 }
 - (id)initWithScrollbar:(Scrollbar*)scrollbar featureToAnimate:(FeatureToAnimate)featureToAnimate animateFrom:(CGFloat)startValue animateTo:(CGFloat)endValue duration:(NSTimeInterval)duration;
 @end
 
 @implementation WebScrollbarPartAnimation
 
 - (id)initWithScrollbar:(Scrollbar*)scrollbar featureToAnimate:(FeatureToAnimate)featureToAnimate animateFrom:(CGFloat)startValue animateTo:(CGFloat)endValue duration:(NSTimeInterval)duration
 {
-    self = [super initWithDuration:duration animationCurve:NSAnimationEaseInOut];
+    self = [super init];
     if (!self)
         return nil;
 
+    _timer = adoptPtr(new WebScrollbarPartAnimationTimer(self, duration));
     _scrollbar = scrollbar;
     _featureToAnimate = featureToAnimate;
     _startValue = startValue;
     _endValue = endValue;
 
-    [self setAnimationBlockingMode:NSAnimationNonblocking];
-
     return self;
 }
 
 - (void)startAnimation
 {
     ASSERT(_scrollbar);
 
     _scrollbarPainter = scrollbarPainterForScrollbar(_scrollbar);
+    _timer->start();
+}
 
-    [super startAnimation];
+- (void)stopAnimation
+{
+    _timer->stop();
+}
+
+- (void)setDuration:(CFTimeInterval)duration
+{
+    _timer->setDuration(duration);
 }
 
 - (void)setStartValue:(CGFloat)startValue
 {
     _startValue = startValue;
 }
 
 - (void)setEndValue:(CGFloat)endValue
 {
     _endValue = endValue;
 }
 
 - (void)setCurrentProgress:(NSAnimationProgress)progress
 {
-    [super setCurrentProgress:progress];
-
     ASSERT(_scrollbar);
 
     CGFloat currentValue;
     if (_startValue > _endValue)
         currentValue = 1 - progress;
     else
         currentValue = progress;
 
     switch (_featureToAnimate) {
     case ThumbAlpha:
@@ skipping 930 matching lines @@
         return;
 
     m_visibleScrollerThumbRect = rectInViewCoordinates;
 }
 
 bool ScrollAnimatorMac::canUseCoordinatedScrollbar() {
     return ScrollbarThemeMacCommon::isOverlayAPIAvailable();
 }
 
 } // namespace blink