Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(101)

Issue 528973002: Refactoring: Unify command mocks in v8 roll tests. (Closed)

Created:
6 years, 3 months ago by Michael Achenbach
Modified:
6 years, 3 months ago
Reviewers:
Jarin
CC:
v8-dev
Project:
v8
Visibility:
Public.

Description

Refactoring: Unify command mocks in v8 roll tests. This unifies all mocks for shell commands (like git, svn, gclient). The command name is now explicitly stated in the test expectations, which allows to correctly test the few commands that are not git. TEST=./script_test.py TBR=jarin@chromium.org Committed: https://code.google.com/p/v8/source/detail?r=23611

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+321 lines, -305 lines) Patch
M tools/push-to-trunk/test_scripts.py View 29 chunks +321 lines, -305 lines 0 comments Download

Messages

Total messages: 4 (1 generated)
Michael Achenbach
PTAL
6 years, 3 months ago (2014-09-02 12:28:44 UTC) #2
Michael Achenbach
Committed patchset #1 (id:1) manually as 23611 (presubmit successful).
6 years, 3 months ago (2014-09-02 12:51:39 UTC) #3
Jarin
6 years, 3 months ago (2014-09-02 12:54:42 UTC) #4
Message was sent while issue was closed.
lgtm

Powered by Google App Engine
This is Rietveld 408576698