Issue 528953003: aw: Ensure fallback tick unsets |block_invalidates_|

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 528953003: aw: Ensure fallback tick unsets |block_invalidates_| (Closed)

Created:
6 years, 3 months ago by boliu

Modified:
6 years, 3 months ago

Reviewers:
boliu

CC:
chromium-reviews, android-webview-reviews_chromium.org

Base URL:
https://chromium.googlesource.com/chromium/src.git@2125

Project:
chromium

Visibility:
Public.

More Reviews

Description

aw: Ensure fallback tick unsets |block_invalidates_| Currently, if |compositor_needs_continuous_invalidate_| is unset before PostFallbackTick or FallbackTickFired, then the fallback ticks are cancelled, but we never unset |block_invalidates_|, which will block invalidates indefinitely. Fix is simply always unset |block_invalidates_| even if we skip the fallback tick. BUG=408779 Review URL: https://codereview.chromium.org/512403002 Cr-Commit-Position: refs/heads/master@{#292511} (cherry picked from commit d3ba7205b5a0c9154b91357c8795e772833fa798) TBR=boliu@chromium.org

Patch Set 1 #

Created: 6 years, 3 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+8 lines, -1 line)			Patch
	M	android_webview/browser/browser_view_renderer.cc	View		2 chunks	+8 lines, -1 line	0 comments	Download

Messages

Total messages: 1 (0 generated)

Expand Messages | Collapse Messages

boliu

6 years, 3 months ago (2014-09-02 15:53:06 UTC) #1

Message was sent while issue was closed.

Committed patchset #1 (id:1) to pending queue manually as 25e6644 (presubmit
successful).

Expand Messages | Collapse Messages