Source/core/loader/FrameLoader.cpp - Issue 52893003: scrollTop and scrollLeft always 0 in DOMContentLoaded handler on a scrolled page

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/core/loader/FrameLoader.cpp

Issue 52893003: scrollTop and scrollLeft always 0 in DOMContentLoaded handler on a scrolled page (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: Created 7 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: Source/core/loader/FrameLoader.cpp

diff --git a/Source/core/loader/FrameLoader.cpp b/Source/core/loader/FrameLoader.cpp

index 4b3db84303fd77417009ede4fe373fbce15d4802..8cda096cb3bf2f61030e3269445fc39213a1986d 100644

--- a/Source/core/loader/FrameLoader.cpp

+++ b/Source/core/loader/FrameLoader.cpp

@@ -1041,7 +1041,8 @@ void FrameLoader::checkLoadCompleteForThisFrame()

void FrameLoader::didFirstLayout()

{

- if (m_frame->page() && isBackForwardLoadType(m_loadType))

+ if (m_frame->page()

+ && (isBackForwardLoadType(m_loadType) || m_loadType == FrameLoadTypeReload || m_loadType == FrameLoadTypeReloadFromOrigin))

Nate Chapin 2013/10/30 19:00:44 It might be good to split this into 2 separate if(

history()->restoreScrollPositionAndViewState();

}

« no previous file with comments | « LayoutTests/fast/loader/scroll-position-restored-on-reload-at-load-event-expected.txt ('k') | no next file » | no next file with comments »