Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(327)

Issue 528843002: use c++03 style enum scope (Closed)

Created:
6 years, 3 months ago by Mostyn Bramley-Moore
Modified:
6 years, 3 months ago
Reviewers:
tkent, sof, pals
CC:
blink-reviews
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Project:
blink
Visibility:
Public.

Description

use c++03 style enum scope Followup to https://codereview.chromium.org/473833002 We haven't officially switched over to using c++11 everywhere yet, so this patch replaces c++11 style enum scope with c++03 style scope. BUG=402749 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=181202

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M Source/core/events/Event.cpp View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 7 (3 generated)
Mostyn Bramley-Moore
@tkent: pleast take a look at this tiny patch.
6 years, 3 months ago (2014-09-01 19:24:37 UTC) #3
sof
lgtm
6 years, 3 months ago (2014-09-01 19:46:53 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/mostynb@opera.com/528843002/1
6 years, 3 months ago (2014-09-01 20:21:14 UTC) #6
commit-bot: I haz the power
6 years, 3 months ago (2014-09-01 21:23:58 UTC) #7
Message was sent while issue was closed.
Committed patchset #1 (id:1) as 181202

Powered by Google App Engine
This is Rietveld 408576698