Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1140)

Issue 528743002: Explicitly #include <algorithm> in media/cast/logging/encoding_event_subscriber.cc (Closed)

Created:
6 years, 3 months ago by Paweł Hajdan Jr.
Modified:
6 years, 3 months ago
Reviewers:
miu
CC:
chromium-reviews, hclam+watch_chromium.org, imcheng+watch_chromium.org, hguihot+watch_chromium.org, jasonroberts+watch_google.com, avayvod+watch_chromium.org, pwestin+watch_google.com, feature-media-reviews_chromium.org, jshin+watch_chromium.org, miu+watch_chromium.org, hubbe+watch_chromium.org, mikhal+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Explicitly #include <algorithm> in media/cast/logging/encoding_event_subscriber.cc This is needed for std::sort. I detected the issue when building against system protobuf-2.6.0. Likely some header is no longer implicitly/indirectly #included. BUG=none R=miu@chromium.org Committed: https://chromium.googlesource.com/chromium/src/+/913c504f761e78fed9de4b0173f6728f1f51874a

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -0 lines) Patch
M media/cast/logging/encoding_event_subscriber.cc View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 11 (7 generated)
Paweł Hajdan Jr.
6 years, 3 months ago (2014-09-01 10:17:17 UTC) #2
miu
lgtm
6 years, 3 months ago (2014-09-01 16:57:02 UTC) #5
Paweł Hajdan Jr.
Committed patchset #1 (id:1) manually as 913c504 (presubmit successful).
6 years, 3 months ago (2014-09-02 08:08:43 UTC) #10
commit-bot: I haz the power
6 years, 3 months ago (2014-09-10 03:17:48 UTC) #11
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/913c504f761e78fed9de4b0173f6728f1f51874a
Cr-Commit-Position: refs/heads/master@{#292903}

Powered by Google App Engine
This is Rietveld 408576698