Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(99)

Issue 528733002: Video Player: Restyle Files.app Cast Selection Menu (Closed)

Created:
6 years, 3 months ago by yoshiki
Modified:
6 years, 3 months ago
Reviewers:
fukino
CC:
chromium-reviews, rginda+watch_chromium.org, mtomasz+watch_chromium.org, yoshiki+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Video Player: Restyle Files.app Cast Selection Menu See the issue (http://crbug.com/407392#5) for the image of restyled design. BUG=407392 TEST=manually tested Committed: https://crrev.com/58ef26a953fdea0fef2301e27c104e440f2320c5 Cr-Commit-Position: refs/heads/master@{#292867}

Patch Set 1 #

Patch Set 2 : Localize the string #

Unified diffs Side-by-side diffs Delta from patch set Stats (+35 lines, -4 lines) Patch
M chrome/app/chromeos_strings.grdp View 1 1 chunk +3 lines, -0 lines 0 comments Download
M chrome/browser/chromeos/extensions/file_manager/private_api_strings.cc View 1 1 chunk +1 line, -0 lines 0 comments Download
M ui/file_manager/video_player/css/cast_menu.css View 1 3 chunks +27 lines, -4 lines 0 comments Download
M ui/file_manager/video_player/js/video_player.js View 1 1 chunk +4 lines, -0 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
yoshiki
@fukino-san, PTAL
6 years, 3 months ago (2014-09-01 09:52:47 UTC) #2
fukino
On 2014/09/01 09:52:47, yoshiki wrote: > @fukino-san, PTAL lgtm.
6 years, 3 months ago (2014-09-01 10:15:27 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/yoshiki@chromium.org/528733002/20001
6 years, 3 months ago (2014-09-01 11:27:42 UTC) #5
commit-bot: I haz the power
Committed patchset #2 (id:20001) as 71e64bd0132b7b88cbac6a3e37f25dc7d4ff3675
6 years, 3 months ago (2014-09-01 12:27:05 UTC) #6
commit-bot: I haz the power
6 years, 3 months ago (2014-09-10 03:16:42 UTC) #7
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/58ef26a953fdea0fef2301e27c104e440f2320c5
Cr-Commit-Position: refs/heads/master@{#292867}

Powered by Google App Engine
This is Rietveld 408576698