Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(190)

Issue 528683002: [fsp] Remove the exclusive field from the CreateDirectory operation. (Closed)

Created:
6 years, 3 months ago by mtomasz
Modified:
6 years, 3 months ago
Reviewers:
benwells, kinaba
CC:
chromium-reviews, extensions-reviews_chromium.org, nkostylev+watch_chromium.org, tzik, nhiroki, oshima+watch_chromium.org, chromium-apps-reviews_chromium.org, stevenjb+watch_chromium.org, kinuko+fileapi, davemoore+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

[fsp] Remove the exclusive field from the CreateDirectory operation. Analogically to CreateFile, we should just return an EXISTS error code if the entry already exists. The EXISTS error code is later converted to OK if the operation was requested to be not 'exclusive'. TBR=benwells@chromium.org TEST=browser_tests, unit_tests: *FileSystemProvider*CreateDirectory* BUG=393141 Committed: https://crrev.com/8cba4967ecfc5edbc0534964c940af9887582dbc Cr-Commit-Position: refs/heads/master@{#292873}

Patch Set 1 #

Patch Set 2 : Fixed a comment. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+29 lines, -42 lines) Patch
M chrome/browser/chromeos/file_system_provider/fake_provided_file_system.h View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/chromeos/file_system_provider/fake_provided_file_system.cc View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/chromeos/file_system_provider/fileapi/provider_async_file_util.cc View 2 chunks +20 lines, -11 lines 0 comments Download
M chrome/browser/chromeos/file_system_provider/operations/create_directory.h View 2 chunks +2 lines, -4 lines 0 comments Download
M chrome/browser/chromeos/file_system_provider/operations/create_directory.cc View 2 chunks +0 lines, -3 lines 0 comments Download
M chrome/browser/chromeos/file_system_provider/operations/create_directory_unittest.cc View 6 chunks +0 lines, -9 lines 0 comments Download
M chrome/browser/chromeos/file_system_provider/provided_file_system.h View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/chromeos/file_system_provider/provided_file_system.cc View 2 chunks +0 lines, -2 lines 0 comments Download
M chrome/browser/chromeos/file_system_provider/provided_file_system_interface.h View 1 chunk +2 lines, -3 lines 0 comments Download
M chrome/common/extensions/api/file_system_provider.idl View 1 2 chunks +4 lines, -5 lines 0 comments Download
M chrome/test/data/extensions/api_test/file_system_provider/create_directory/test.js View 1 chunk +1 line, -2 lines 0 comments Download

Messages

Total messages: 14 (5 generated)
mtomasz
@kinaba: PTAL. Thanks.
6 years, 3 months ago (2014-09-01 05:55:52 UTC) #2
kinaba
lgtm
6 years, 3 months ago (2014-09-01 08:01:35 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/mtomasz@chromium.org/528683002/1
6 years, 3 months ago (2014-09-01 08:09:55 UTC) #5
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). The failing builders are: chromium_presubmit on tryserver.chromium.linux ...
6 years, 3 months ago (2014-09-01 09:00:31 UTC) #6
commit-bot: I haz the power
Try jobs failed on following builders: chromium_presubmit on tryserver.chromium.linux (http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presubmit/builds/7996)
6 years, 3 months ago (2014-09-01 09:04:26 UTC) #8
mtomasz
@benwells: TBR for the IDL change.
6 years, 3 months ago (2014-09-01 09:11:05 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/mtomasz@chromium.org/528683002/20001
6 years, 3 months ago (2014-09-01 09:12:00 UTC) #12
commit-bot: I haz the power
Committed patchset #2 (id:20001) as 8016593aa165dcb5eeb752bb77d5ccb3cfdc9be1
6 years, 3 months ago (2014-09-01 13:53:12 UTC) #13
commit-bot: I haz the power
6 years, 3 months ago (2014-09-10 03:16:54 UTC) #14
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/8cba4967ecfc5edbc0534964c940af9887582dbc
Cr-Commit-Position: refs/heads/master@{#292873}

Powered by Google App Engine
This is Rietveld 408576698