Issue 52843004: Revert r1784: SK_API on a non-concrete template is strange.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 52843004: Revert r1784: SK_API on a non-concrete template is strange. (Closed)

Created:
7 years, 1 month ago by bungeman-skia

Modified:
7 years, 1 month ago

Reviewers:
bsalomon

CC:
skia-review_googlegroups.com

Base URL:
http://skia.googlecode.com/svn/trunk/

Visibility:
Public.

More Reviews

Description

Revert r1784: SK_API on a non-concrete template is strange. TBR=bsalomon@google.com Committed: https://code.google.com/p/skia/source/detail?r=12040

Patch Set 1 #

Created: 7 years, 1 month ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+1 line, -1 line)			Patch
	M	include/core/SkTemplates.h	View		1 chunk	+1 line, -1 line	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

bsalomon

7 years, 1 month ago (2013-10-31 12:47:44 UTC) #2

Message was sent while issue was closed.

On 2013/10/30 22:22:09, bungeman1 wrote:
> Committed patchset #1 manually as r12040.

If it's not necessary then lgtm. I don't remember why I originally did that.

Expand Messages | Collapse Messages