Issue 52843003: Don't check if shaders compile or program links in release Chromium

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 52843003: Don't check if shaders compile or program links in release Chromium (Closed)

Created:
7 years, 1 month ago by bsalomon

Modified:
7 years, 1 month ago

Reviewers:
robertphillips

CC:
skia-review_googlegroups.com

Base URL:
https://skia.googlecode.com/svn/trunk

Visibility:
Public.

Don't check if shaders compile or program links in release Chromium Committed: http://code.google.com/p/skia/source/detail?r=12032

Total comments: 1

Created: 7 years, 1 month ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+87 lines, -52 lines)			Patch
M	src/gpu/gl/GrGLContext.h	View	1 2 3	2 chunks	+5 lines, -0 lines	0 comments	Download
M	src/gpu/gl/GrGLContext.cpp	View		4 chunks	+10 lines, -1 line	0 comments	Download
M	src/gpu/gl/GrGLShaderBuilder.cpp	View	1 2 3 4	8 chunks	+64 lines, -49 lines	0 comments	Download
M	src/gpu/gl/GrGLUtil.h	View		2 chunks	+2 lines, -0 lines	0 comments	Download
M	src/gpu/gl/GrGLUtil.cpp	View		1 chunk	+4 lines, -0 lines	0 comments	Download
M	src/gpu/gl/GrGpuGL.h	View		2 chunks	+2 lines, -2 lines	0 comments	Download

Total messages: 5 (0 generated)

robertphillips

lgtm (modulo moving shader compilation up). I am leery of making this so Chromium specific. ...

7 years, 1 month ago (2013-10-30 19:46:18 UTC) #2

bsalomon

updated to fix the compile issue and also added comment about exposing a "check fewer ...

7 years, 1 month ago (2013-10-30 19:49:59 UTC) #3

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://skia-tree-status.appspot.com/cq/bsalomon@google.com/52843003/120001

7 years, 1 month ago (2013-10-30 19:53:08 UTC) #4

Message was sent while issue was closed.

Change committed as 12032