BrowserPlugin Cleanup: Simplify update device scale factor

BrowserPlugin Cleanup: Simplify update device scale factor

This CL removes the passed parameter of device_scale_factor and in BrowserPlugin::UpdateDeviceScaleFactor since it's not used.

This CL also removes GetSizeParams because it's only used once.

Repaints are now set whenever the device scale factor changes.

Also remove all calls to .get() on scoped_ptrs which are unnecessary.

BUG=none
TBR=creis@chromium.org for trivial render_view_impl change.

Committed: https://crrev.com/2f5c8d6545f1c6e6e386a6f3a50059befd87e1dd
Cr-Commit-Position: refs/heads/master@{#293197}

[Fady Samuel, 2014-09-03 16:45:19]

fsamuel@chromium.org changed reviewers:
+ creis@chromium.org, lazyboy@chromium.org

[Fady Samuel, 2014-09-03 16:45:19]

+lazyboy@: for browser_plugin changes
+creis for render_view_impl.cc

[lazyboy, 2014-09-03 16:58:31]

https://codereview.chromium.org/528383003/diff/1/content/renderer/browser_plu...
File content/renderer/browser_plugin/browser_plugin.cc (left):

https://codereview.chromium.org/528383003/diff/1/content/renderer/browser_plu...
content/renderer/browser_plugin/browser_plugin.cc:152: if
(compositing_helper_.get())
I think this should stay as is, IIUC we are removing implicit conversion from
scoped_refptr to T*, http://crbug.com/110610

https://codereview.chromium.org/528383003/diff/1/content/renderer/render_view...
File content/renderer/render_view_impl.cc (left):

https://codereview.chromium.org/528383003/diff/1/content/renderer/render_view...
content/renderer/render_view_impl.cc:3661: if (browser_plugin_manager_.get())
Same as above.

[Fady Samuel, 2014-09-03 17:30:52]

PTAL

https://codereview.chromium.org/528383003/diff/1/content/renderer/browser_plu...
File content/renderer/browser_plugin/browser_plugin.cc (left):

https://codereview.chromium.org/528383003/diff/1/content/renderer/browser_plu...
content/renderer/browser_plugin/browser_plugin.cc:152: if
(compositing_helper_.get())
On 2014/09/03 16:58:31, lazyboy wrote:
> I think this should stay as is, IIUC we are removing implicit conversion from
> scoped_refptr to T*, http://crbug.com/110610

Done.

https://codereview.chromium.org/528383003/diff/1/content/renderer/render_view...
File content/renderer/render_view_impl.cc (left):

https://codereview.chromium.org/528383003/diff/1/content/renderer/render_view...
content/renderer/render_view_impl.cc:3661: if (browser_plugin_manager_.get())
On 2014/09/03 16:58:31, lazyboy wrote:
> Same as above.

Done.

[lazyboy, 2014-09-03 17:34:27]

lgtm

[Fady Samuel, 2014-09-03 17:56:48]

The CQ bit was checked by fsamuel@chromium.org

[commit-bot: I haz the power, 2014-09-03 17:58:45]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/fsamuel@chromium.org/528383003/20001

[commit-bot: I haz the power, 2014-09-03 18:54:32]

FYI, CQ is re-trying this CL (attempt #1).
The failing builders are:
  linux_chromium_rel_swarming on tryserver.chromium.linux
(http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[commit-bot: I haz the power, 2014-09-03 19:30:56]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-09-03 19:30:57]

Try jobs failed on following builders:
  linux_chromium_rel_swarming on tryserver.chromium.linux
(http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[Fady Samuel, 2014-09-03 19:34:30]

The CQ bit was checked by fsamuel@chromium.org

[commit-bot: I haz the power, 2014-09-03 19:34:59]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/fsamuel@chromium.org/528383003/20001

[commit-bot: I haz the power, 2014-09-03 20:17:11]

FYI, CQ is re-trying this CL (attempt #1).
The failing builders are:
  linux_chromium_rel_swarming on tryserver.chromium.linux
(http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[commit-bot: I haz the power, 2014-09-03 21:20:54]

Committed patchset #2 (id:20001) as 78dfe41a97c66eea2f64ce85037b6562d01c5027

[commit-bot: I haz the power, 2014-09-10 03:27:47]

Patchset 2 (id:??) landed as
https://crrev.com/2f5c8d6545f1c6e6e386a6f3a50059befd87e1dd
Cr-Commit-Position: refs/heads/master@{#293197}

[Charlie Reis, 2014-09-10 04:51:21]

creis@chromium.org changed reviewers:
+ dcheng@chromium.org

[Charlie Reis, 2014-09-10 04:51:22]

[+dcheng]

render_view_impl.cc LGTM, but removing .get()s on scoped_ptrs is not ok.  Daniel
is removing implicit conversions in http://crbug.com/110610 because they're
dangerous (easy to leak or cause UaFs).

[lazyboy, 2014-09-10 15:54:54]

On 2014/09/10 04:51:22, Charlie Reis wrote:
> [+dcheng]
> 
> render_view_impl.cc LGTM, but removing .get()s on scoped_ptrs is not ok. 
Daniel
> is removing implicit conversions in http://crbug.com/110610 because they're
> dangerous (easy to leak or cause UaFs).

I believe this is about scoped_refptrs as opposed to scoped_ptrs?
This CL doesn't remove implicit conversions from scoped_refptr<T> to T*.
The ones that are done are all scoped_ptrs.

[Charlie Reis, 2014-09-10 23:18:40]

On 2014/09/10 15:54:54, lazyboy wrote:
> On 2014/09/10 04:51:22, Charlie Reis wrote:
> > [+dcheng]
> > 
> > render_view_impl.cc LGTM, but removing .get()s on scoped_ptrs is not ok. 
> Daniel
> > is removing implicit conversions in http://crbug.com/110610 because they're
> > dangerous (easy to leak or cause UaFs).
> 
> I believe this is about scoped_refptrs as opposed to scoped_ptrs?
> This CL doesn't remove implicit conversions from scoped_refptr<T> to T*.
> The ones that are done are all scoped_ptrs.

Thanks, works for me.