Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(35)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 528373003: Make CustomElementSchedular static (Closed)

Created:
6 years, 3 months ago by deepak.sa
Modified:
6 years, 3 months ago
CC:
blink-reviews, blink-reviews-dom_chromium.org, dglazkov+blink, eae+blinkwatch, rwlbuis, sof, webcomponents-bugzilla_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Project:
blink
Visibility:
Public.

Description

Make CustomElementSchedular static This patch removes the instance() function and adds a new function callbackQueues() to keep the map in the schedular itself. This function will return the map. Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=181456

Patch Set 1 #

Patch Set 2 : Rebase #

Patch Set 3 : Fix compile error #

Total comments: 2

Patch Set 4 : Removed trace() #

Patch Set 5 : Removed empty BUG= line #

Unified diffs Side-by-side diffs Delta from patch set Stats (+45 lines, -72 lines) Patch
M Source/core/dom/custom/CustomElementProcessingStack.h View 1 1 chunk +0 lines, -2 lines 0 comments Download
M Source/core/dom/custom/CustomElementScheduler.h View 1 2 3 1 chunk +0 lines, -16 lines 0 comments Download
M Source/core/dom/custom/CustomElementScheduler.cpp View 1 2 3 4 chunks +45 lines, -54 lines 0 comments Download

Messages

Total messages: 12 (5 generated)
deepak.sa
PTAL? Thanks!
6 years, 3 months ago (2014-09-03 16:45:19 UTC) #2
esprehn
https://codereview.chromium.org/528373003/diff/40001/Source/core/dom/custom/CustomElementScheduler.cpp File Source/core/dom/custom/CustomElementScheduler.cpp (right): https://codereview.chromium.org/528373003/diff/40001/Source/core/dom/custom/CustomElementScheduler.cpp#newcode157 Source/core/dom/custom/CustomElementScheduler.cpp:157: void CustomElementScheduler::trace(Visitor* visitor) Remove this method. https://codereview.chromium.org/528373003/diff/40001/Source/core/dom/custom/CustomElementScheduler.h File Source/core/dom/custom/CustomElementScheduler.h ...
6 years, 3 months ago (2014-09-04 02:22:43 UTC) #3
deepak.sa
+dominicc
6 years, 3 months ago (2014-09-04 05:28:49 UTC) #5
esprehn
lgtm
6 years, 3 months ago (2014-09-05 00:50:48 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/deepak.sa@samsung.com/528373003/60001
6 years, 3 months ago (2014-09-05 05:22:59 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/deepak.sa@samsung.com/528373003/80001
6 years, 3 months ago (2014-09-05 06:03:03 UTC) #11
commit-bot: I haz the power
6 years, 3 months ago (2014-09-05 09:23:29 UTC) #12
Message was sent while issue was closed. 
Committed patchset #5 (id:80001) as 181456

Powered by Google App Engine
This is Rietveld 408576698