Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2566)

Unified Diff: chrome/browser/renderer_host/web_cache_manager_browsertest.cc

Issue 528363002: Move webCacheManager to //components. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: rebase Created 6 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/renderer_host/web_cache_manager_browsertest.cc
diff --git a/chrome/browser/renderer_host/web_cache_manager_browsertest.cc b/chrome/browser/renderer_host/web_cache_manager_browsertest.cc
deleted file mode 100644
index 7caee2f6ec2c893ec7e68d0636da5a64b5a9ee3d..0000000000000000000000000000000000000000
--- a/chrome/browser/renderer_host/web_cache_manager_browsertest.cc
+++ /dev/null
@@ -1,69 +0,0 @@
-// Copyright (c) 2012 The Chromium Authors. All rights reserved.
-// Use of this source code is governed by a BSD-style license that can be
-// found in the LICENSE file.
-
-#include <string>
-
-#include "base/message_loop/message_loop.h"
-#include "chrome/browser/renderer_host/web_cache_manager.h"
-#include "chrome/browser/ui/browser.h"
-#include "chrome/browser/ui/browser_commands.h"
-#include "chrome/browser/ui/tabs/tab_strip_model.h"
-#include "chrome/test/base/in_process_browser_test.h"
-#include "chrome/test/base/ui_test_utils.h"
-#include "content/public/browser/render_process_host.h"
-#include "content/public/browser/web_contents.h"
-#include "content/public/common/result_codes.h"
-#include "testing/gtest/include/gtest/gtest.h"
-
-using content::WebContents;
-
-class WebCacheManagerBrowserTest : public InProcessBrowserTest {
-};
-
-// Regression test for http://crbug.com/12362. If a renderer crashes and the
-// user navigates to another tab and back, the browser doesn't crash.
-IN_PROC_BROWSER_TEST_F(WebCacheManagerBrowserTest, CrashOnceOnly) {
- const base::FilePath kTestDir(FILE_PATH_LITERAL("google"));
- const base::FilePath kTestFile(FILE_PATH_LITERAL("google.html"));
- GURL url(ui_test_utils::GetTestUrl(kTestDir, kTestFile));
-
- ui_test_utils::NavigateToURL(browser(), url);
-
- chrome::NewTab(browser());
- ui_test_utils::NavigateToURL(browser(), url);
-
- WebContents* tab = browser()->tab_strip_model()->GetWebContentsAt(0);
- ASSERT_TRUE(tab != NULL);
- base::KillProcess(tab->GetRenderProcessHost()->GetHandle(),
- content::RESULT_CODE_KILLED, true);
-
- browser()->tab_strip_model()->ActivateTabAt(0, true);
- chrome::NewTab(browser());
- ui_test_utils::NavigateToURL(browser(), url);
-
- browser()->tab_strip_model()->ActivateTabAt(0, true);
- chrome::NewTab(browser());
- ui_test_utils::NavigateToURL(browser(), url);
-
- // We would have crashed at the above line with the bug.
-
- browser()->tab_strip_model()->ActivateTabAt(0, true);
- chrome::CloseTab(browser());
- browser()->tab_strip_model()->ActivateTabAt(0, true);
- chrome::CloseTab(browser());
- browser()->tab_strip_model()->ActivateTabAt(0, true);
- chrome::CloseTab(browser());
-
- ui_test_utils::NavigateToURL(browser(), url);
-
- // Depending on the speed of execution of the unload event, we may have one or
- // two active renderers at that point (one executing the unload event in
- // background).
- EXPECT_GE(WebCacheManager::GetInstance()->active_renderers_.size(), 1U);
- EXPECT_LE(WebCacheManager::GetInstance()->active_renderers_.size(), 2U);
- EXPECT_EQ(
- WebCacheManager::GetInstance()->inactive_renderers_.size(), 0U);
- EXPECT_GE(WebCacheManager::GetInstance()->stats_.size(), 1U);
- EXPECT_LE(WebCacheManager::GetInstance()->stats_.size(), 2U);
-}

Powered by Google App Engine
This is Rietveld 408576698