Move webCacheManager to //components.

components/web_cache/browser/web_cache_manager_unittest.cc

Index: components/web_cache/browser/web_cache_manager_unittest.cc
diff --git a/chrome/browser/renderer_host/web_cache_manager_unittest.cc b/components/web_cache/browser/web_cache_manager_unittest.cc
similarity index 93%
rename from chrome/browser/renderer_host/web_cache_manager_unittest.cc
rename to components/web_cache/browser/web_cache_manager_unittest.cc
index 81a201190b4225f3484bf9548c46a24bfe35906b..037ac15ae5b3917646b333eca9b677c9a258d074 100644
--- a/chrome/browser/renderer_host/web_cache_manager_unittest.cc
+++ b/components/web_cache/browser/web_cache_manager_unittest.cc
@@ -5,7 +5,7 @@
 #include <string>
 
 #include "base/message_loop/message_loop.h"
-#include "chrome/browser/renderer_host/web_cache_manager.h"
+#include "components/web_cache/browser/web_cache_manager.h"
 #include "content/public/test/test_browser_thread.h"
 #include "testing/gtest/include/gtest/gtest.h"
 
@@ -14,6 +14,8 @@ using base::TimeDelta;
 using content::BrowserThread;
 using blink::WebCache;
 
+namespace web_cache {
+
 class WebCacheManagerTest : public testing::Test {
  protected:
   typedef WebCacheManager::StatsMap StatsMap;
@@ -309,3 +311,24 @@ TEST_F(WebCacheManagerTest, AddToStrategyTest) {
   manager()->Remove(kRendererID);
   manager()->Remove(kRendererID2);
 }
+
+TEST_F(WebCacheManagerTest,

[erikwright (departed), 2014/09/10 18:06:55]

Add a comment explaining that Add, Remove, and ObserveActivity trigger deferred
calls to ReviseAllocationStrategy and that we call it directly after each
operation to sidestep the need to wait for an unobservable background operation.

[Xi Han, 2014/09/11 13:52:15]

Good point, otherwise people will get confused when reading this test. 

+       RemoveRendererBeforeCallingObserveActivityShouldNotCrashTest) {
+  EXPECT_EQ(0U, active_renderers(manager()).size());
+  EXPECT_EQ(0U, inactive_renderers(manager()).size());
+
+  manager()->Add(kRendererID);
+  manager()->ReviseAllocationStrategy();
+  manager()->Add(kRendererID2);
+  manager()->ReviseAllocationStrategy();
+
+  manager()->Remove(kRendererID);
+  manager()->ReviseAllocationStrategy();
+
+  manager()->ObserveActivity(kRendererID);

[erikwright (departed), 2014/09/10 18:06:55]

Add a call to ReviseAllocationStrategy here.

[Xi Han, 2014/09/11 13:52:15]

Done.

+
+  manager()->Remove(kRendererID2);
+  manager()->ReviseAllocationStrategy();

[erikwright (departed), 2014/09/10 18:06:55]

Add something that verifies the behaviour when a renderer is removed in the
200ms between ObserveActivity and ReviseAllocationStrategy being invoked. i.e.:

Add(X)
ObserveActivity(X)
Remove(X)
ReviseAllocationStrategy()

This could be accomplished by just adding a call to
ObserveActivity(kRendererID2) before the call to Remove(kRendererID2).

Be sure to add a comment explaining what the sequence is meant to cover.

[Xi Han, 2014/09/11 13:52:15]

As discussed offline, to prevent similar failure in the future, I added another
5 tests to cover all the orderings of these three operation: Remove(ID),
ObserveActivity(ID), Remove(ID2).



On 2014/09/10 18:06:55, erikwright wrote:

+}
+
+}  // namespace web_cache