Move webCacheManager to //components.

components/web_cache/browser/web_cache_manager_browsertest.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include <string>
 
 #include "base/message_loop/message_loop.h"
-#include "chrome/browser/renderer_host/web_cache_manager.h"
 #include "chrome/browser/ui/browser.h"
 #include "chrome/browser/ui/browser_commands.h"
 #include "chrome/browser/ui/tabs/tab_strip_model.h"
 #include "chrome/test/base/in_process_browser_test.h"
 #include "chrome/test/base/ui_test_utils.h"
+#include "components/web_cache/browser/web_cache_manager.h"
 #include "content/public/browser/render_process_host.h"
 #include "content/public/browser/web_contents.h"
 #include "content/public/common/result_codes.h"
 #include "testing/gtest/include/gtest/gtest.h"
 
 using content::WebContents;
 
+namespace web_cache {
+
 class WebCacheManagerBrowserTest : public InProcessBrowserTest {
 };
 
 // Regression test for http://crbug.com/12362.  If a renderer crashes and the
 // user navigates to another tab and back, the browser doesn't crash.
 IN_PROC_BROWSER_TEST_F(WebCacheManagerBrowserTest, CrashOnceOnly) {

[erikwright (departed), 2014/09/08 19:20:00]

As far as I can tell, this test is for a regression that would occur when a
render process crashes.

ContentBrowserTest::CreateBrowser returns instances of Shell, each of which
corresponds to a separate WebContents. I wonder if you could write this test in
terms of those, instead of in terms of tabs.

I don't know what about this test ensured that the two tabs were in distinct
processes (or if that is, in fact, a precondition for the crash), but presumably
there is a way to ensure that with the content shell, too, if necessary.

I would, of course, validate that the test is still legitimate by reverting the
fix
(http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/renderer_host/...)
and ensuring that the newly refactored test crashes.

   const base::FilePath kTestDir(FILE_PATH_LITERAL("google"));
   const base::FilePath kTestFile(FILE_PATH_LITERAL("google.html"));
   GURL url(ui_test_utils::GetTestUrl(kTestDir, kTestFile));
 
   ui_test_utils::NavigateToURL(browser(), url);
 
   chrome::NewTab(browser());
   ui_test_utils::NavigateToURL(browser(), url);
 
   WebContents* tab = browser()->tab_strip_model()->GetWebContentsAt(0);
@@ skipping 23 matching lines @@
   // Depending on the speed of execution of the unload event, we may have one or
   // two active renderers at that point (one executing the unload event in
   // background).
   EXPECT_GE(WebCacheManager::GetInstance()->active_renderers_.size(), 1U);
   EXPECT_LE(WebCacheManager::GetInstance()->active_renderers_.size(), 2U);
   EXPECT_EQ(
       WebCacheManager::GetInstance()->inactive_renderers_.size(), 0U);
   EXPECT_GE(WebCacheManager::GetInstance()->stats_.size(), 1U);
   EXPECT_LE(WebCacheManager::GetInstance()->stats_.size(), 2U);
 }
+
+}  // namespace web_cache