components/web_cache/browser/BUILD.gn - Issue 528363002: Move webCacheManager to //components.

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: components/web_cache/browser/BUILD.gn

Issue 528363002: Move webCacheManager to //components. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Remove an unnecessary dependency in web_cache.gypi. Created 6 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

OLD	NEW
1 # Copyright 2014 The Chromium Authors. All rights reserved.	1 # Copyright 2014 The Chromium Authors. All rights reserved.

2 # Use of this source code is governed by a BSD-style license that can be	2 # Use of this source code is governed by a BSD-style license that can be

3 # found in the LICENSE file.	3 # found in the LICENSE file.

4	4

5 import("//build/config/features.gni")

6

7 static_library("browser") {	5 static_library("browser") {

	6 output_name = "web_cache_browser"

8 sources = [	7 sources = [

9 "open_pdf_in_reader_prompt_client.h",	8 "web_cache_manager.cc",

10 "pdf_web_contents_helper.cc",	9 "web_cache_manager.h",

11 "pdf_web_contents_helper.h",

12 "pdf_web_contents_helper_client.h",

13 ]	10 ]

14	11

15 deps = [	12 deps = [

16 "//components/pdf/common",	13 "//base",

	14 "//components/web_cache/common",

17 "//content/public/browser",	15 "//content/public/browser",

	16 "//content/test:test_support",
	James Cook 2014/09/05 16:53:18 Why does this need test_support? Shouldn't that on Why does this need test_support? Shouldn't that only be needed for the tests? Xi Han 2014/09/05 19:39:25 Great catch, thanks! Show quoted text On 2014/09/05 16:53:18, James Cook wrote: > Why does this need test_support? Shouldn't that only be needed for the tests? Great catch, thanks!
	17 "//third_party/WebKit/public:blink",

18 ]	18 ]

19 }	19 }

OLD	NEW