tools/telemetry/telemetry/core/backends/chrome/android_browser_finder.py - Issue 52833002: Purge unpinned ashmem before parsing /proc/$pid/smaps.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: tools/telemetry/telemetry/core/backends/chrome/android_browser_finder.py

Issue 52833002: Purge unpinned ashmem before parsing /proc/$pid/smaps. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Update documentation Created 7 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « tools/telemetry/telemetry/core/backends/adb_commands.py ('k') | tools/telemetry/telemetry/core/platform/android_platform_backend.py » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: tools/telemetry/telemetry/core/backends/chrome/android_browser_finder.py

diff --git a/tools/telemetry/telemetry/core/backends/chrome/android_browser_finder.py b/tools/telemetry/telemetry/core/backends/chrome/android_browser_finder.py

index 1d8107454c5c9beabdabf73662b8f63ab4436395..f956cedb4bbe931909a7d025754f823a49cfb28a 100644

--- a/tools/telemetry/telemetry/core/backends/chrome/android_browser_finder.py

+++ b/tools/telemetry/telemetry/core/backends/chrome/android_browser_finder.py

@@ -232,7 +232,7 @@ def FindAllAvailableBrowsers(finder_options, logging=real_logging):

logging.warn('telemetry detected an android device. However,')

logging.warn('Chrome\'s port-forwarder app is not available.')

logging.warn('Falling back to prebuilt binaries, but to build locally: ')

- logging.warn(' ninja -C out/Release forwarder2 md5sum')

+ logging.warn(' ninja -C out/Release android_tools')

logging.warn('')

if not adb_commands.SetupPrebuiltTools(device):