Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(142)

Issue 528293003: Moved misplaced allDataReceived() assert (Closed)

Created:
6 years, 3 months ago by sugoi1
Modified:
6 years, 3 months ago
CC:
blink-reviews, jamesr, krit, jbroman, danakj, Rik, Stephen Chennney, pdr., rwlbuis
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Project:
blink
Visibility:
Public.

Description

Moved misplaced allDataReceived() assert The spots where allDataReceived() was checked in an if statement, or asserted against were switched, so the release build was going right through the code in getYUVComponentSizes(), without returning early, which could lead to a crash. Added safety checks inside the JPEG decoder just in case we get into this situation some other way. BUG=410788, 410586 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=181439

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+7 lines, -3 lines) Patch
M Source/platform/graphics/ImageFrameGenerator.cpp View 2 chunks +3 lines, -3 lines 0 comments Download
M Source/platform/image-decoders/jpeg/JPEGImageDecoder.cpp View 1 chunk +4 lines, -0 lines 0 comments Download

Messages

Total messages: 14 (6 generated)
sugoi1
6 years, 3 months ago (2014-09-04 20:53:11 UTC) #2
Noel Gordon
lgtm
6 years, 3 months ago (2014-09-05 02:43:42 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/sugoi@chromium.org/528293003/1
6 years, 3 months ago (2014-09-05 02:47:36 UTC) #6
commit-bot: I haz the power
Try jobs failed on following builders: blink_presubmit on tryserver.blink (http://build.chromium.org/p/tryserver.blink/builders/blink_presubmit/builds/14455)
6 years, 3 months ago (2014-09-05 02:55:49 UTC) #8
Noel Gordon
+tkent for a rubber stamp.
6 years, 3 months ago (2014-09-05 03:04:30 UTC) #9
tkent
rs lgtm
6 years, 3 months ago (2014-09-05 05:41:13 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/sugoi@chromium.org/528293003/1
6 years, 3 months ago (2014-09-05 05:42:11 UTC) #13
commit-bot: I haz the power
6 years, 3 months ago (2014-09-05 05:47:44 UTC) #14
Message was sent while issue was closed.
Committed patchset #1 (id:1) as 181439

Powered by Google App Engine
This is Rietveld 408576698