YCM works correctly when 'out' directory is a symlink (continued).

YCM works correctly when 'out' directory is a symlink (continued).

It used to work after my previous fix 37accc2cd, but then it broke again.
This CL changes the way how "-I" arguments are transformed.

BUG=NONE
TEST=manually
NOTRY=true

Committed: https://crrev.com/95e4bfd7a9fd1333343a5a6bfc7c6ef03cbe10ce
Cr-Commit-Position: refs/heads/master@{#293519}

[dzhioev (left Google), 2014-09-03 12:38:32]

dzhioev@chromium.org changed reviewers:
+ eroman@chromium.org

[eroman, 2014-09-03 19:56:08]

Can you explain this change in more detail?
I am not convinced that this is correct, unless I am misunderstanding the
use-case or how gyp works.

So at gyp generation time, an output directory is chosen, and include paths are
baked into it, like for instance

-I../../third_party/angle/src

These baked in paths are relative and need to reach back to the containing
chromium "src" directory.

How does gyp generate these? Does it assume that "out" is within the "src"
directory? What do the bake paths look like if gyp is run on an output directory
that is not contained within "src", does it generate absolute paths instead or
does it still write this as "../../"?

Thanks

[dzhioev (left Google), 2014-09-04 17:44:38]

On 2014/09/03 19:56:08, eroman wrote:
> Can you explain this change in more detail?
> I am not convinced that this is correct, unless I am misunderstanding the
> use-case or how gyp works.
> 
> So at gyp generation time, an output directory is chosen, and include paths
are
> baked into it, like for instance
> 
> -I../../third_party/angle/src
> 
> These baked in paths are relative and need to reach back to the containing
> chromium "src" directory.
> 
> How does gyp generate these? Does it assume that "out" is within the "src"
> directory? What do the bake paths look like if gyp is run on an output
directory
> that is not contained within "src", does it generate absolute paths instead or
> does it still write this as "../../"?
> 
> Thanks

gyp doesn't assume that 'out' is inside the 'src' directory. It calculates all
the paths
within 'src' relatively to path of 'out'.
My set up: chrome sources are in [HOME]/chromium/src, 'out' is a symlink to
'/media/HDD/out'.
Gyp generates include paths like
'-I../../../..[HOME]/chromium/src/third_party/skia/include/core'.

Without this CL include paths generated by the config script are all like
-I[HOME][HOME]/chromium/src/third_party/cacheinvalidation/google/cacheinvalidation

[eroman, 2014-09-04 20:43:21]

LGTM then, thanks for the explanation

[dzhioev (left Google), 2014-09-05 14:38:09]

The CQ bit was checked by dzhioev@chromium.org

[commit-bot: I haz the power, 2014-09-05 14:39:15]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/dzhioev@chromium.org/528293002/1

[commit-bot: I haz the power, 2014-09-05 14:40:44]

Committed patchset #1 (id:1) as 70a8dcdcaa2c19c11d82f9ac8d460d0af2ee3f81

[commit-bot: I haz the power, 2014-09-10 03:39:32]

Patchset 1 (id:??) landed as
https://crrev.com/95e4bfd7a9fd1333343a5a6bfc7c6ef03cbe10ce
Cr-Commit-Position: refs/heads/master@{#293519}