This is a reland of ServiceWorkerCache::Keys.

This is a reland of ServiceWorkerCache::Keys.

Reland of https://codereview.chromium.org/477973002/

There was a memory leak.  EndEnumeration wasn't called on the iterator.  

Fixed and tested with ASAN.

The leak was detected because SimpleCache doesn't clean up its enumerators on deletion, but it should.  See https://code.google.com/p/chromium/issues/detail?id=410276

BUG=392621
Committed: https://crrev.com/bb2bb40a73a860a941cb81cfdc4dc3b9a9ee16a1
Cr-Commit-Position: refs/heads/master@{#293326}

[jkarlin, 2014-09-03 11:01:24]

Patchset #1 (id:1) has been deleted

[jkarlin, 2014-09-03 11:02:35]

Patchset #2 (id:40001) has been deleted

[jkarlin, 2014-09-03 13:01:22]

jkarlin@chromium.org changed reviewers:
+ michaeln@chromium.org

[jkarlin, 2014-09-03 13:01:23]

michaeln@chromium.org: Please review changes in all.

[jsbell, 2014-09-03 16:36:41]

On 2014/09/03 13:01:23, jkarlin wrote:
> mailto:michaeln@chromium.org: Please review changes in all.

I'm not an owner but the fix LGTM

[michaeln1, 2014-09-03 21:01:53]

still lgtm2

[jkarlin, 2014-09-03 21:56:32]

The CQ bit was checked by jkarlin@chromium.org

[michaeln, 2014-09-03 22:29:31]

doh... and lgtm too

[jkarlin, 2014-09-03 22:42:47]

The CQ bit was unchecked by jkarlin@chromium.org

[jkarlin, 2014-09-03 22:42:54]

The CQ bit was checked by jkarlin@chromium.org

[commit-bot: I haz the power, 2014-09-03 23:23:33]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/jkarlin@chromium.org/528233003/10004

[commit-bot: I haz the power, 2014-09-04 02:00:30]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-09-04 02:00:31]

Try jobs failed on following builders:
  android_clang_dbg_recipe on tryserver.chromium.linux
(http://build.chromium.org/p/tryserver.chromium.linux/builders/android_clang_d...)

[jkarlin, 2014-09-04 10:49:20]

The CQ bit was checked by jkarlin@chromium.org

[commit-bot: I haz the power, 2014-09-04 10:51:06]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/jkarlin@chromium.org/528233003/10004

[commit-bot: I haz the power, 2014-09-04 11:42:16]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-09-04 11:42:17]

Try jobs failed on following builders:
  android_clang_dbg_recipe on tryserver.chromium.linux
(http://build.chromium.org/p/tryserver.chromium.linux/builders/android_clang_d...)

[jkarlin, 2014-09-04 12:13:32]

The CQ bit was checked by jkarlin@chromium.org

[commit-bot: I haz the power, 2014-09-04 12:14:43]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/jkarlin@chromium.org/528233003/70001

[jkarlin, 2014-09-04 17:20:50]

The CQ bit was unchecked by jkarlin@chromium.org

[jkarlin, 2014-09-04 17:20:56]

The CQ bit was checked by jkarlin@chromium.org

[jkarlin, 2014-09-04 17:21:07]

The CQ bit was unchecked by jkarlin@chromium.org

[jkarlin, 2014-09-04 17:22:12]

The CQ bit was checked by jkarlin@chromium.org

[commit-bot: I haz the power, 2014-09-04 17:27:14]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/jkarlin@chromium.org/528233003/70001

[commit-bot: I haz the power, 2014-09-04 19:47:18]

Committed patchset #3 (id:70001) as a3a3703b91203db3e2248d656b86cb26bf2e30e3

[jkarlin, 2014-09-04 23:22:04]

A revert of this CL (patchset #3 id:70001) has been created in
https://codereview.chromium.org/538263002/ by jkarlin@chromium.org.

The reason for reverting is: Now getting a Valgrind leak that is likely due to
this CL: 

Suppression (error hash=#935FB14CBC8B5858#):
For more info on using suppressions see
http://dev.chromium.org/developers/tree-sheriffs/sheriff-details-chromium/mem...
{
<insert_a_suppression_name_here>
Memcheck:Leak
fun:_Znw*
fun:_ZN9__gnu_cxx13new_allocatorIN10disk_cache20SimpleEntryOperationEE8allocateEmPKv
fun:_ZNSt11_Deque_baseIN10disk_cache20SimpleEntryOperationESaIS1_EE16_M_allocate_nodeEv
fun:_ZNSt5dequeIN10disk_cache20SimpleEntryOperationESaIS1_EE16_M_push_back_auxIJS1_EEEvDpOT_
fun:_ZNSt5dequeIN10disk_cache20SimpleEntryOperationESaIS1_EE12emplace_backIJS1_EEEvDpOT_
fun:_ZNSt5dequeIN10disk_cache20SimpleEntryOperationESaIS1_EE9push_backEOS1_
fun:_ZNSt5queueIN10disk_cache20SimpleEntryOperationESt5dequeIS1_SaIS1_EEE4pushEOS1_
fun:_ZN10disk_cache15SimpleEntryImpl5CloseEv
fun:_ZN10disk_cache12EntryDeleterclEPNS_5EntryE
fun:_ZN4base8internal15scoped_ptr_implIN10disk_cache5EntryENS2_12EntryDeleterEED2Ev
fun:_ZN10scoped_ptrIN10disk_cache5EntryENS0_12EntryDeleterEED2Ev
}.

[commit-bot: I haz the power, 2014-09-10 03:32:20]

Patchset 3 (id:??) landed as
https://crrev.com/bb2bb40a73a860a941cb81cfdc4dc3b9a9ee16a1
Cr-Commit-Position: refs/heads/master@{#293326}