Issue 52823006: Small crash fix for set pages dialog drag'n'drop issue.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 52823006: Small crash fix for set pages dialog drag'n'drop issue. (Closed)

Created:
7 years, 1 month ago by Dan Beam

Modified:
7 years, 1 month ago

Reviewers:
Nico

CC:
chromium-reviews, dbeam+watch-options_chromium.org, dcheng

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

Created: 7 years, 1 month ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+7 lines, -1 line)			Patch
	M	chrome/browser/custom_home_pages_table_model.cc	View		1 chunk	+1 line, -1 line	0 comments	Download
	M	chrome/browser/ui/webui/options/options_browsertest.js	View		1 chunk	+6 lines, -0 lines	0 comments	Download

Total messages: 5 (0 generated)

Dan Beam

this picks up dcheng@'s CL [1] and adds a test for thakis@. the goal is ...

7 years, 1 month ago (2013-11-04 20:42:52 UTC) #1

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/dbeam@chromium.org/52823006/1

7 years, 1 month ago (2013-11-05 00:22:13 UTC) #3

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/dbeam@chromium.org/52823006/1

7 years, 1 month ago (2013-11-05 03:09:04 UTC) #4

Message was sent while issue was closed.

Change committed as 232971