Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(50)

Issue 52823002: x11: Move XInput2 availability information out of the message pump. (Closed)

Created:
7 years, 1 month ago by sadrul
Modified:
7 years, 1 month ago
CC:
chromium-reviews, ben+aura_chromium.org, yusukes+watch_chromium.org, derat+watch_chromium.org, tfarina, kalyank, ben+views_chromium.org, erikwright+watch_chromium.org
Visibility:
Public.

Description

x11: Move XInput2 availability information out of the message pump. BUG=302696 R=darin@chromium.org, derat@chromium.org Previously committed in r233414, but reverted in r233416 because it collided with r233347. Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=233528

Patch Set 1 #

Patch Set 2 : . #

Patch Set 3 : . #

Patch Set 4 : . #

Patch Set 5 : debug #

Patch Set 6 : . #

Patch Set 7 : more-debug #

Patch Set 8 : . #

Patch Set 9 : remove-all-aura #

Patch Set 10 : . #

Patch Set 11 : . #

Patch Set 12 : . #

Patch Set 13 : . #

Patch Set 14 : . #

Patch Set 15 : . #

Patch Set 16 : all-clean #

Patch Set 17 : link-fix #

Patch Set 18 : . #

Patch Set 19 : . #

Unified diffs Side-by-side diffs Delta from patch set Stats (+75 lines, -44 lines) Patch
M base/message_loop/message_pump_x11.h View 7 8 9 1 chunk +0 lines, -3 lines 0 comments Download
M base/message_loop/message_pump_x11.cc View 7 8 9 13 14 3 chunks +1 line, -11 lines 0 comments Download
M ui/aura/root_window_host_x11.cc View 1 7 8 9 11 12 13 3 chunks +4 lines, -2 lines 0 comments Download
M ui/base/x/x11_util.h View 1 chunk +3 lines, -1 line 0 comments Download
M ui/base/x/x11_util.cc View 1 2 3 4 5 6 7 8 1 chunk +4 lines, -0 lines 0 comments Download
M ui/events/events.gyp View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 3 chunks +15 lines, -7 lines 0 comments Download
M ui/events/x/device_data_manager.h View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 3 chunks +5 lines, -2 lines 0 comments Download
M ui/events/x/device_data_manager.cc View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 6 chunks +19 lines, -2 lines 0 comments Download
M ui/events/x/device_list_cache_x.h View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 3 chunks +9 lines, -4 lines 0 comments Download
M ui/events/x/device_list_cache_x.cc View 1 4 chunks +6 lines, -6 lines 0 comments Download
M ui/events/x/touch_factory_x11.h View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 2 chunks +2 lines, -2 lines 0 comments Download
M ui/events/x/touch_factory_x11.cc View 1 2 3 4 5 6 7 8 3 chunks +5 lines, -3 lines 0 comments Download
M ui/views/widget/desktop_aura/desktop_root_window_host_x11.cc View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 2 chunks +2 lines, -1 line 0 comments Download

Messages

Total messages: 6 (0 generated)
sadrul
7 years, 1 month ago (2013-10-30 17:06:54 UTC) #1
Daniel Erat
lgtm
7 years, 1 month ago (2013-10-30 18:15:50 UTC) #2
sadrul
+darin@ for base/ changes.
7 years, 1 month ago (2013-10-30 19:41:55 UTC) #3
darin (slow to review)
LGTM for src/base/
7 years, 1 month ago (2013-10-30 20:15:49 UTC) #4
sadrul
Committed patchset #16 manually as r233414 (presubmit successful).
7 years, 1 month ago (2013-11-06 23:21:26 UTC) #5
sadrul
7 years, 1 month ago (2013-11-07 07:31:55 UTC) #6
Message was sent while issue was closed.
Committed patchset #19 manually as r233528 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698