Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1313)

Unified Diff: runtime/vm/benchmark_test.cc

Issue 528073002: Don't leak memory between iterations of the message serialization benchmarks. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart
Patch Set: Created 6 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « runtime/tests/vm/vm.status ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: runtime/vm/benchmark_test.cc
diff --git a/runtime/vm/benchmark_test.cc b/runtime/vm/benchmark_test.cc
index 8e58da5446f47423f1db1537f07440d7bce4b825..00b39e5acb9d92a7f9229e6223dc3473bbe455e7 100644
--- a/runtime/vm/benchmark_test.cc
+++ b/runtime/vm/benchmark_test.cc
@@ -511,6 +511,7 @@ BENCHMARK(SerializeNull) {
Timer timer(true, "Serialize Null");
timer.Start();
for (intptr_t i = 0; i < kLoopCount; i++) {
+ StackZone zone(isolate);
MessageWriter writer(&buffer, &message_allocator);
writer.WriteMessage(null_object);
intptr_t buffer_len = writer.BytesWritten();
@@ -533,6 +534,7 @@ BENCHMARK(SerializeSmi) {
Timer timer(true, "Serialize Smi");
timer.Start();
for (intptr_t i = 0; i < kLoopCount; i++) {
+ StackZone zone(isolate);
MessageWriter writer(&buffer, &message_allocator);
writer.WriteMessage(smi_object);
intptr_t buffer_len = writer.BytesWritten();
@@ -557,6 +559,7 @@ BENCHMARK(SimpleMessage) {
Timer timer(true, "Simple Message");
timer.Start();
for (intptr_t i = 0; i < kLoopCount; i++) {
+ StackZone zone(isolate);
MessageWriter writer(&buffer, &malloc_allocator);
writer.WriteMessage(array_object);
intptr_t buffer_len = writer.BytesWritten();
« no previous file with comments | « runtime/tests/vm/vm.status ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698