Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1419)

Issue 52803009: BMM: Split initialization into two phases (Closed)

Created:
7 years, 1 month ago by arv (Not doing code reviews)
Modified:
7 years, 1 month ago
Reviewers:
yosin_UTC9, Dan Beam
CC:
chromium-reviews, tfarina, arv+watch_chromium.org
Visibility:
Public.

Description

BMM: Split initialization into two phases getStrings is async and when it is done it sets the loadTimeData. However, we depend on the loadTimeData to be present before the call to getStrings returns. Have getStrings callback continue the initialization. BUG=312356 R=dbeam@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=233077

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -1 line) Patch
M chrome/browser/resources/bookmark_manager/js/main.js View 1 chunk +5 lines, -1 line 0 comments Download

Messages

Total messages: 10 (0 generated)
arv (Not doing code reviews)
7 years, 1 month ago (2013-11-04 21:08:57 UTC) #1
Dan Beam
rs lgtm
7 years, 1 month ago (2013-11-04 21:46:42 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/arv@chromium.org/52803009/1
7 years, 1 month ago (2013-11-04 22:10:41 UTC) #3
commit-bot: I haz the power
Step "update" is always a major failure. Look at the try server FAQ for more ...
7 years, 1 month ago (2013-11-04 23:22:08 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/arv@chromium.org/52803009/1
7 years, 1 month ago (2013-11-05 14:33:08 UTC) #5
commit-bot: I haz the power
Retried try job too often on win_rel for step(s) chrome_frame_tests http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=win_rel&number=219642
7 years, 1 month ago (2013-11-05 16:06:19 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/arv@chromium.org/52803009/1
7 years, 1 month ago (2013-11-05 17:45:56 UTC) #7
commit-bot: I haz the power
Retried try job too often on win_rel for step(s) browser_tests http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=win_rel&number=219851
7 years, 1 month ago (2013-11-05 20:32:28 UTC) #8
arv (Not doing code reviews)
On 2013/11/05 20:32:28, I haz the power (commit-bot) wrote: > Retried try job too often ...
7 years, 1 month ago (2013-11-05 20:35:55 UTC) #9
arv (Not doing code reviews)
7 years, 1 month ago (2013-11-05 20:36:46 UTC) #10
Message was sent while issue was closed.
Committed patchset #1 manually as r233077 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698