Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(122)

Unified Diff: tools/testing/dart/browser_controller.dart

Issue 52803007: Adds checked mode to Dartium on Android browser test controller. (Closed) Base URL: http://dart.googlecode.com/svn/branches/bleeding_edge/dart/
Patch Set: Created 7 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: tools/testing/dart/browser_controller.dart
===================================================================
--- tools/testing/dart/browser_controller.dart (revision 29745)
+++ tools/testing/dart/browser_controller.dart (working copy)
@@ -494,10 +494,11 @@
class AndroidBrowser extends Browser {
+ final bool checkedMode;
AdbDevice _adbDevice;
AndroidBrowserConfig _config;
- AndroidBrowser(this._adbDevice, this._config);
+ AndroidBrowser(this._adbDevice, this._config, this.checkedMode);
Future<bool> start(String url) {
var intent = new Intent(
@@ -511,6 +512,12 @@
}).then((_) {
return _adbDevice.setProp("DART_FORWARDING_PRINT", "1");
}).then((_) {
+ if (checkedMode) {
+ return _adbDevice.setProp("DART_FLAGS", "--checked");
+ } else {
+ return _adbDevice.setProp("DART_FLAGS", "");
+ }
+ }).then((_) {
return _adbDevice.startActivity(intent).then((_) => true);
});
}
@@ -715,7 +722,7 @@
/**
* Encapsulates all the functionality for running tests in browsers.
- * The interface is rather simple. After starting the runner tests
+ * The interface is rather simple. After starting, the runner tests
* are simply added to the queue and a the supplied callbacks are called
* whenever a test completes.
*/
@@ -788,9 +795,9 @@
var androidBrowserCreationMapping = {
'chromeOnAndroid' : (AdbDevice device) => new AndroidChrome(device),
'ContentShellOnAndroid' : (AdbDevice device) =>
- new AndroidBrowser(device, contentShellOnAndroidConfig),
+ new AndroidBrowser(device, contentShellOnAndroidConfig, checkedMode),
'DartiumOnAndroid' : (AdbDevice device) =>
- new AndroidBrowser(device, dartiumOnAndroidConfig),
+ new AndroidBrowser(device, dartiumOnAndroidConfig, checkedMode),
};
if (androidBrowserCreationMapping.containsKey(browserName)) {
AdbHelper.listDevices().then((deviceIds) {
@@ -915,10 +922,12 @@
browser = new AndroidChrome(adbDeviceMapping[id]);
} else if (browserName == 'ContentShellOnAndroid') {
browser = new AndroidBrowser(adbDeviceMapping[id],
- contentShellOnAndroidConfig);
+ contentShellOnAndroidConfig,
+ checkedMode);
} else if (browserName == 'DartiumOnAndroid') {
browser = new AndroidBrowser(adbDeviceMapping[id],
- dartiumOnAndroidConfig);
+ dartiumOnAndroidConfig,
+ checkedMode);
} else {
browserStatus.remove(id);
browser = getInstance();
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698