Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(205)

Issue 52803006: Move FontFallbackWin to platform/ (Closed)

Created:
7 years, 1 month ago by pilgrim_google
Modified:
7 years, 1 month ago
Reviewers:
abarth-chromium
CC:
blink-reviews, jamesr, dsinclair, danakj, Rik, Stephen Chennney, pdr., darin (slow to review)
Visibility:
Public.

Description

Move FontFallbackWin to platform/ BUG=297477 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=161347

Patch Set 1 #

Patch Set 2 : fix include #

Patch Set 3 : fix more includes #

Patch Set 4 : move to platform/fonts #

Unified diffs Side-by-side diffs Delta from patch set Stats (+9 lines, -420 lines) Patch
M Source/core/core.gypi View 1 2 3 1 chunk +0 lines, -2 lines 0 comments Download
M Source/core/platform/graphics/chromium/FontCacheChromiumWin.cpp View 1 2 3 1 chunk +1 line, -1 line 0 comments Download
D Source/core/platform/graphics/chromium/FontFallbackWin.h View 1 chunk +0 lines, -64 lines 0 comments Download
D Source/core/platform/graphics/chromium/FontFallbackWin.cpp View 1 chunk +0 lines, -348 lines 0 comments Download
M Source/core/platform/graphics/chromium/UniscribeHelper.cpp View 1 2 3 1 chunk +1 line, -1 line 0 comments Download
M Source/core/platform/graphics/skia/FontCacheSkiaWin.cpp View 1 2 3 1 chunk +1 line, -1 line 0 comments Download
M Source/platform/blink_platform.gypi View 1 2 3 1 chunk +2 lines, -0 lines 0 comments Download
A + Source/platform/fonts/FontFallbackWin.h View 1 2 3 3 chunks +3 lines, -2 lines 0 comments Download
A + Source/platform/fonts/FontFallbackWin.cpp View 1 2 3 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 5 (0 generated)
pilgrim_google
7 years, 1 month ago (2013-11-04 15:21:49 UTC) #1
abarth-chromium
I think we're putting font-related files in http://src.chromium.org/viewvc/blink/trunk/Source/platform/fonts/
7 years, 1 month ago (2013-11-04 17:06:34 UTC) #2
abarth-chromium
LGTM presuming you move the file to http://src.chromium.org/viewvc/blink/trunk/Source/platform/fonts/
7 years, 1 month ago (2013-11-04 17:07:20 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/pilgrim@chromium.org/52803006/120001
7 years, 1 month ago (2013-11-05 15:02:22 UTC) #4
commit-bot: I haz the power
7 years, 1 month ago (2013-11-05 16:30:01 UTC) #5
Message was sent while issue was closed.
Change committed as 161347

Powered by Google App Engine
This is Rietveld 408576698