src/hydrogen.cc - Issue 527963002: Implement loads and calls from 'super'

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/hydrogen.cc

Issue 527963002: Implement loads and calls from 'super' (Closed) Base URL: https://v8.googlecode.com/svn/branches/bleeding_edge

Patch Set: CR feedback Created 6 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: src/hydrogen.cc

diff --git a/src/hydrogen.cc b/src/hydrogen.cc

index 169df22aa8293093add0c5275fb7343b00118c6e..8ce9e4b266054a4643bbf4f4cc3692d0192c3d61 100644

--- a/src/hydrogen.cc

+++ b/src/hydrogen.cc

@@ -11187,7 +11187,10 @@ void HOptimizedGraphBuilder::VisitThisFunction(ThisFunction* expr) {

void HOptimizedGraphBuilder::VisitSuperReference(SuperReference* expr) {

- UNREACHABLE();

+ DCHECK(!HasStackOverflow());

+ DCHECK(current_block() != NULL);

+ DCHECK(current_block()->HasPredecessor());

+ return Bailout(kSuperReference);

}