Issue 527943002: [Most Visited] Check for Sync state when using SuggestionsService.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 527943002: [Most Visited] Check for Sync state when using SuggestionsService. (Closed)

Created:
6 years, 3 months ago by Mathieu

Modified:
6 years, 3 months ago

Reviewers:
manzagop (departed), erikwright (departed), newt (away)

CC:
chromium-reviews, skanuj+watch_chromium.org, melevin+watch_chromium.org, dhollowa+watch_chromium.org, dougw+watch_chromium.org, donnd+watch_chromium.org, dominich, jfweitz+watch_chromium.org, David Black, samarth+watch_chromium.org, kmadhusu+watch_chromium.org, Jered

Base URL:
https://chromium.googlesource.com/chromium/src.git@2125

Project:
chromium

Visibility:
Public.

More Reviews

Description

[Most Visited] Check for Sync state when using SuggestionsService. BUG=386454 R=manzagop@chromium.org, newt@chromium.org TBR=erikwright TEST=SuggestionsServiceTest Review URL: https://codereview.chromium.org/473123002 Cr-Commit-Position: refs/heads/master@{#291116} git-svn-id: svn://svn.chromium.org/chrome/trunk/src@291116 0039d316-1c4b-4281-b951-d872f2087c98 (cherry picked from commit 1d1ab156d1fc06d62109f35e5400568e78bda578) Committed: https://chromium.googlesource.com/chromium/src/+/76082ea4311464aeca1eeba0b67754d44f72a772

Patch Set 1 #

Created: 6 years, 3 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+234 lines, -41 lines)			Patch
M	chrome/browser/android/most_visited_sites.h	View	3 chunks	+6 lines, -1 line	0 comments	Download
M	chrome/browser/android/most_visited_sites.cc	View	7 chunks	+37 lines, -3 lines	0 comments	Download
M	chrome/browser/search/suggestions/suggestions_source.cc	View	2 chunks	+4 lines, -0 lines	0 comments	Download
M	components/suggestions.gypi	View	1 chunk	+2 lines, -0 lines	0 comments	Download
M	components/suggestions/BUILD.gn	View	1 chunk	+2 lines, -0 lines	0 comments	Download
M	components/suggestions/suggestions_service.h	View	3 chunks	+20 lines, -10 lines	0 comments	Download
M	components/suggestions/suggestions_service.cc	View	4 chunks	+44 lines, -27 lines	0 comments	Download
M	components/suggestions/suggestions_service_unittest.cc	View	4 chunks	+59 lines, -0 lines	0 comments	Download
A	components/suggestions/suggestions_utils.h	View	1 chunk	+38 lines, -0 lines	0 comments	Download
A	components/suggestions/suggestions_utils.cc	View	1 chunk	+22 lines, -0 lines	0 comments	Download

Messages

Total messages: 1 (0 generated)

Expand Messages | Collapse Messages

Message was sent while issue was closed.

Committed patchset #1 (id:1) manually as 76082ea.

Expand Messages | Collapse Messages