Issue 527933002: Unify some PlatformCodeStubs.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 527933002: Unify some PlatformCodeStubs. (Closed)

Created:
6 years, 3 months ago by Yang

Modified:
6 years, 3 months ago

Reviewers:
mvstanton

CC:
v8-dev

Base URL:
https://v8.googlecode.com/svn/branches/bleeding_edge

Project:
v8

Visibility:
Public.

More Reviews

Description

Unify some PlatformCodeStubs. R=mvstanton@chromium.org Committed: https://code.google.com/p/v8/source/detail?r=23631

Patch Set 1 #

Total comments: 1

Created: 6 years, 3 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+163 lines, -360 lines)			Patch
M	src/arm/code-stubs-arm.h	View	5 chunks	+3 lines, -46 lines	0 comments	Download
M	src/arm/code-stubs-arm.cc	View	8 chunks	+21 lines, -41 lines	1 comment	Download
M	src/arm64/code-stubs-arm64.h	View	3 chunks	+17 lines, -67 lines	0 comments	Download
M	src/arm64/code-stubs-arm64.cc	View	8 chunks	+21 lines, -32 lines	0 comments	Download
M	src/code-stubs.h	View	1 chunk	+47 lines, -0 lines	0 comments	Download
M	src/ia32/code-stubs-ia32.h	View	4 chunks	+6 lines, -47 lines	0 comments	Download
M	src/ia32/code-stubs-ia32.cc	View	8 chunks	+19 lines, -36 lines	0 comments	Download
M	src/x64/code-stubs-x64.h	View	4 chunks	+9 lines, -52 lines	0 comments	Download
M	src/x64/code-stubs-x64.cc	View	8 chunks	+20 lines, -39 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

mvstanton

Nice solution, there was really no need for them to be platform independent! LGTM. https://codereview.chromium.org/527933002/diff/1/src/arm/code-stubs-arm.cc ...

6 years, 3 months ago (2014-09-02 12:38:36 UTC) #2

Yang

6 years, 3 months ago (2014-09-03 07:20:17 UTC) #3

Message was sent while issue was closed.

Committed patchset #1 (id:1) manually as 23631 (presubmit successful).

Expand Messages | Collapse Messages