Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(19)

Issue 527923002: Do not paste clipboard contents when middle click on a bookmark in Bookmark Manager. (Closed)

Created:
6 years, 3 months ago by Gaja
Modified:
6 years, 3 months ago
Reviewers:
Bernhard Bauer
CC:
chromium-reviews, tfarina, arv+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Do not paste clipboard contents when middle click on a bookmark in Bookmark Manager. Middle click on a bookmark in Bookmark Manager should open the bookmark in new tab without pasting the contents of paste buffer. In Linux, since middle click is used as 'paste', prevent it from pasting if the clicked item is a bookmark. If clicked elsewhere in the Bookmark Manager window, do the default behaviour. BUG=44811 R=bauerb@chromium.org TEST= 1) Add few bookmarks and open Bookmark Manager. 2) Copy one or more bookmark item(s). 3) Middle click on a bookmark item and observe. 4) The clicked bookmark should open in new tab without pasting the copied bookmark inside the window. Committed: https://crrev.com/233c5a88c8ad7fbaba83c7822e7d6ae10162cdef Cr-Commit-Position: refs/heads/master@{#293382}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -0 lines) Patch
M chrome/browser/resources/bookmark_manager/js/bmm/bookmark_list.js View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 7 (1 generated)
Gaja
PTAL.
6 years, 3 months ago (2014-09-02 12:25:07 UTC) #1
Gaja
On 2014/09/02 12:25:07, Gajendra N wrote: > PTAL. @bauerb PTAL.
6 years, 3 months ago (2014-09-04 12:25:41 UTC) #2
Bernhard Bauer
LGTM!
6 years, 3 months ago (2014-09-04 12:27:29 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/gajendra.n@samsung.com/527923002/1
6 years, 3 months ago (2014-09-04 12:28:46 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1) as 80bb8e4c0a9658f664ae0a2101d24a4751275935
6 years, 3 months ago (2014-09-05 00:45:34 UTC) #6
commit-bot: I haz the power
6 years, 3 months ago (2014-09-10 03:34:20 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/233c5a88c8ad7fbaba83c7822e7d6ae10162cdef
Cr-Commit-Position: refs/heads/master@{#293382}

Powered by Google App Engine
This is Rietveld 408576698