Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(489)

Issue 527913002: Don't change the window disposition for new windows without a user gesture (Closed)

Created:
6 years, 3 months ago by jochen (gone - plz use gerrit)
Modified:
6 years, 3 months ago
Reviewers:
Bernhard Bauer
CC:
chromium-reviews, creis+watch_chromium.org, darin-cc_chromium.org, jam, nasko+codewatch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Don't change the window disposition for new windows without a user gesture The popup blocker will block them anyways, and if it's disabled, we shouldn't change the disposition chosen by the web page BUG=158274 Committed: https://crrev.com/c5cfa6423d112b5ff0bb2a863ebe5fe2f5ac7cc3 Cr-Commit-Position: refs/heads/master@{#292931}

Patch Set 1 #

Patch Set 2 : updates #

Unified diffs Side-by-side diffs Delta from patch set Stats (+29 lines, -28 lines) Patch
M chrome/browser/extensions/window_open_apitest.cc View 1 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/browser/ui/blocked_content/popup_blocker_browsertest.cc View 1 6 chunks +27 lines, -17 lines 0 comments Download
M content/renderer/render_view_impl.cc View 1 chunk +0 lines, -9 lines 0 comments Download

Messages

Total messages: 11 (4 generated)
jochen (gone - plz use gerrit)
Bernhard, mind having a look?
6 years, 3 months ago (2014-09-02 12:10:11 UTC) #2
Bernhard Bauer
LGTM, in particular in light of Darin's comment.
6 years, 3 months ago (2014-09-02 12:11:55 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/jochen@chromium.org/527913002/1
6 years, 3 months ago (2014-09-02 12:18:04 UTC) #5
jochen (gone - plz use gerrit)
fyi, updated test expectations of the failing tests.
6 years, 3 months ago (2014-09-02 13:02:43 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/jochen@chromium.org/527913002/20001
6 years, 3 months ago (2014-09-02 14:43:21 UTC) #9
commit-bot: I haz the power
Committed patchset #2 (id:20001) as f0eec1fd6fdf7bb7b8a18bce18ffb3c8e814efca
6 years, 3 months ago (2014-09-02 15:31:48 UTC) #10
commit-bot: I haz the power
6 years, 3 months ago (2014-09-10 03:18:39 UTC) #11
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/c5cfa6423d112b5ff0bb2a863ebe5fe2f5ac7cc3
Cr-Commit-Position: refs/heads/master@{#292931}

Powered by Google App Engine
This is Rietveld 408576698