Issue 527893002: Fix Win64 build (header include mess up)

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 527893002: Fix Win64 build (header include mess up) (Closed)

Created:
6 years, 3 months ago by Jarin

Modified:
6 years, 3 months ago

Reviewers:
Benedikt Meurer

CC:
v8-dev

Base URL:
https://v8.googlecode.com/svn/branches/bleeding_edge

Project:
v8

Visibility:
Public.

More Reviews

Description

Fix Win64 build (header include mess up) R=bmeurer@chromium.org BUG= Committed: https://code.google.com/p/v8/source/detail?r=23599

Patch Set 2 : Move to linkage.cc #

Patch Set 3 : Remove from operator properties #

Total comments: 1

Patch Set 4 : Add comment #

Created: 6 years, 3 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+20 lines, -20 lines)			Patch
	M	src/compiler/linkage.cc	View	1 2 3	1 chunk	+20 lines, -0 lines	0 comments	Download
	M	src/compiler/linkage-impl.h	View	1	1 chunk	+0 lines, -20 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

Benedikt Meurer

LGTM with nit. https://codereview.chromium.org/527893002/diff/40001/src/compiler/linkage.cc File src/compiler/linkage.cc (right): https://codereview.chromium.org/527893002/diff/40001/src/compiler/linkage.cc#newcode112 src/compiler/linkage.cc:112: bool Linkage::NeedsFrameState(Runtime::FunctionId function) { Nit: add ...

6 years, 3 months ago (2014-09-02 11:31:25 UTC) #2

Jarin

6 years, 3 months ago (2014-09-02 11:33:37 UTC) #3

Message was sent while issue was closed.

Committed patchset #4 (id:60001) manually as 23599 (tree was closed).