Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(924)

Unified Diff: net/http/http_response_headers.h

Issue 527883002: Modified to resolve TODO in parseversion in http_response_headers.cc (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Modified to include overflow logic and other comments Created 6 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « AUTHORS ('k') | net/http/http_response_headers.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: net/http/http_response_headers.h
diff --git a/net/http/http_response_headers.h b/net/http/http_response_headers.h
index ddab798c0a2c0795556d1b2da0a583574c581553..09f6199f11d1a8a52a20a9718f5a7d204e3e4dcd 100644
--- a/net/http/http_response_headers.h
+++ b/net/http/http_response_headers.h
@@ -307,6 +307,12 @@ class NET_EXPORT HttpResponseHeaders
static HttpVersion ParseVersion(std::string::const_iterator line_begin,
std::string::const_iterator line_end);
+ // Helper function for ParseVersion to handle multiple digits and leading
+ // zeros in Http Version
+ static bool ParseVersionInternal(std::string::const_iterator version_begin,
+ std::string::const_iterator version_end,
+ uint32* value);
+
// Tries to extract the status line from a header block, given the first
// line of said header block. If the status line is malformed, we'll
// construct a valid one. Example input:
« no previous file with comments | « AUTHORS ('k') | net/http/http_response_headers.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698