linux_aura: Move the first creation of DesktopScreen after ResourceBundle initialization.

linux_aura: Move the first creation of DesktopScreen after ResourceBundle initialization.

Move the first creation of DesktopScreen after ResourceBundle initialization.
This is necessary for HIDPI enabling as ResourceBundle is the also a place where platform-supported scale factors are initialized.

BUG=315045
Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=233730

[Elliot Glaysher, 2013-11-04 19:08:20]

bug number in the description?

https://codereview.chromium.org/52783003/diff/1/chrome/browser/ui/aura/chrome...
File chrome/browser/ui/aura/chrome_browser_main_extra_parts_aura.h (right):

https://codereview.chromium.org/52783003/diff/1/chrome/browser/ui/aura/chrome...
chrome/browser/ui/aura/chrome_browser_main_extra_parts_aura.h:25: virtual void
PreCreateThreads() OVERRIDE;
These should be in the order specified in
chrome/browser/chrome_browser_main_extra_parts.h

[Mikhail, 2013-11-05 11:15:29]

https://codereview.chromium.org/52783003/diff/1/chrome/browser/ui/aura/chrome...
File chrome/browser/ui/aura/chrome_browser_main_extra_parts_aura.h (right):

https://codereview.chromium.org/52783003/diff/1/chrome/browser/ui/aura/chrome...
chrome/browser/ui/aura/chrome_browser_main_extra_parts_aura.h:25: virtual void
PreCreateThreads() OVERRIDE;
On 2013/11/04 19:08:20, Elliot Glaysher wrote:
> These should be in the order specified in
> chrome/browser/chrome_browser_main_extra_parts.h

Ah, I was sure it is.. probably took the order from some wrong place :/ Thanks
for pointing this out!

[Ben Goodger (Google), 2013-11-05 17:44:11]

https://codereview.chromium.org/52783003/diff/130001/chrome/browser/ui/aura/c...
File chrome/browser/ui/aura/chrome_browser_main_extra_parts_aura.cc (right):

https://codereview.chromium.org/52783003/diff/130001/chrome/browser/ui/aura/c...
chrome/browser/ui/aura/chrome_browser_main_extra_parts_aura.cc:78:
views::CreateDesktopScreen());
Where's the ResourceBundle dependency here? I took a look in the implementations
of CreateDesktopScreen and couldn't see it.

[Mikhail, 2013-11-06 08:46:50]

On 2013/11/05 17:44:11, Ben Goodger (Google) wrote:
>
https://codereview.chromium.org/52783003/diff/130001/chrome/browser/ui/aura/c...
> File chrome/browser/ui/aura/chrome_browser_main_extra_parts_aura.cc (right):
> 
>
https://codereview.chromium.org/52783003/diff/130001/chrome/browser/ui/aura/c...
> chrome/browser/ui/aura/chrome_browser_main_extra_parts_aura.cc:78:
> views::CreateDesktopScreen());
> Where's the ResourceBundle dependency here? I took a look in the
implementations
> of CreateDesktopScreen and couldn't see it.

Yeah, at the moment CreateDesktopScreen does not have dependency on resource
bundle but introducing HIDPI support for linux aura will bring the dependency:
please see https://codereview.chromium.org/27156003/.

[Mikhail, 2013-11-07 12:09:50]

Any update here, please?
This is a blocker for https://codereview.chromium.org/27156003/

[Ben Goodger (Google), 2013-11-07 16:24:13]

ok. lgtm.


On Thu, Nov 7, 2013 at 4:09 AM, <mikhail.pozdnyakov@intel.com> wrote:

> Any update here, please?
> This is a blocker for https://codereview.chromium.org/27156003/
>
> https://codereview.chromium.org/52783003/
>

To unsubscribe from this group and stop receiving emails from it, send an email
to chromium-reviews+unsubscribe@chromium.org.

[commit-bot: I haz the power, 2013-11-07 16:44:12]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/mikhail.pozdnyakov@intel.com/52783003/...

[commit-bot: I haz the power, 2013-11-08 00:39:25]

Change committed as 233730