Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3677)

Unified Diff: chrome/browser/enumerate_modules_model_unittest_win.cc

Issue 5278012: EnumerateModules: Address UI review comments.... (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src/
Patch Set: '' Created 10 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/enumerate_modules_model_unittest_win.cc
===================================================================
--- chrome/browser/enumerate_modules_model_unittest_win.cc (revision 67523)
+++ chrome/browser/enumerate_modules_model_unittest_win.cc (working copy)
@@ -160,9 +160,19 @@
kStandardModule,
{ kMatchName, kMatchLocation, kMatchSignature,
kEmpty, kVersionHigh, ModuleEnumerator::SEE_LINK }
+ }, { // Matches: Name, Location, Version lower is inclusive => Confirmed.
+ ModuleEnumerator::CONFIRMED_BAD,
+ kStandardModule,
+ { kMatchName, kMatchLocation, kMatchSignature,
+ "1.0", "2.0", ModuleEnumerator::SEE_LINK }
+ }, { // Matches: Name, Location, Version higher is exclusive => No match.
+ ModuleEnumerator::NOT_MATCHED,
+ kStandardModule,
+ { kMatchName, kMatchLocation, kEmpty,
+ "0.0", "1.0", ModuleEnumerator::SEE_LINK }
}, { // All empty fields doesn't produce a match.
ModuleEnumerator::NOT_MATCHED,
- {kType, kStatus, L"", L"", L"", L"", L""},
+ { kType, kStatus, L"", L"", L"", L"", L""},
{ "a.dll", "", "", "", "", ModuleEnumerator::SEE_LINK }
},
};

Powered by Google App Engine
This is Rietveld 408576698