Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(86)

Issues Search
    My Issues | Starred     Open | Closed | All

Side by Side Diff: chrome/browser/resources/about_conflicts.html

Issue 5278012: EnumerateModules: Address UI review comments.... (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src/
Patch Set: '' Created 10 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « chrome/browser/enumerate_modules_model_win.cc ('k') | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 <!DOCTYPE HTML> 1 <!DOCTYPE HTML>
2 <html i18n-values="dir:textdirection;"> 2 <html i18n-values="dir:textdirection;">
3 <head> 3 <head>
4 <meta charset="utf-8"> 4 <meta charset="utf-8">
5 <style> 5 <style>
6 body { 6 body {
7 margin: 10px; 7 margin: 10px;
8 min-width: 47em; 8 min-width: 47em;
9 } 9 }
10 10
(...skipping 110 matching lines...) Expand 10 before | Expand all | Expand 10 after
121 font-weight: bold; 121 font-weight: bold;
122 } 122 }
123 123
124 .no-modules { 124 .no-modules {
125 margin: 6em 0 0; 125 margin: 6em 0 0;
126 text-align: center; 126 text-align: center;
127 font-size: 1.2em; 127 font-size: 1.2em;
128 } 128 }
129 129
130 .suspected-bad { 130 .suspected-bad {
131 color: orange; 131 color: #DD7700;
132 } 132 }
133 133
134 .confirmed-bad { 134 .confirmed-bad {
135 color: red; 135 color: red;
136 } 136 }
137
138 .nowrap {
139 white-space: nowrap;
140 }
141
142 .extra-info-text {
143 margin-top: -1em;
Nico 2010/11/29 22:02:34 i'm a bit surprised by the negative top margin. ma
144 margin-bottom: 1em;
145 }
137 </style> 146 </style>
138 <script> 147 <script>
139 148
140 /** 149 /**
141 * This variable structure is here to document the structure that the template 150 * This variable structure is here to document the structure that the template
142 * expects to correctly populate the page. 151 * expects to correctly populate the page.
143 */ 152 */
144 var moduleListDataFormat = { 153 var moduleListDataFormat = {
145 'moduleList': [ 154 'moduleList': [
146 { 155 {
(...skipping 76 matching lines...) Expand 10 before | Expand all | Expand 10 after
223 232
224 </div> 233 </div>
225 </div> 234 </div>
226 235
227 <div class="content"> 236 <div class="content">
228 <div class="module-name no-modules" 237 <div class="module-name no-modules"
229 jsdisplay="moduleList.length === 0"> 238 jsdisplay="moduleList.length === 0">
230 <div i18n-content="modulesNoneLoaded">NO_MODULES_ARE_AVAILABLE</div> 239 <div i18n-content="modulesNoneLoaded">NO_MODULES_ARE_AVAILABLE</div>
231 </div> 240 </div>
232 241
233 <div jsdisplay="moduleList.length > 0"> 242 <div jsdisplay="moduleList.length &gt; 0">
234 <div class="module" jsselect="moduleList"> 243 <table width="100%" cellpadding="0" cellspacing="0">
235 <table width="100%" cellpadding="0" cellspacing="0"> 244 <tr class="module-loaded">
236 <tr class="module-loaded"> 245 <td valign="top">
237 <td valign="top"> 246 <table cellpadding="2" cellspacing="0" border="0">
238 <table cellpadding="2" cellspacing="0"> 247 <tr jsselect="moduleList">
239 <tr> 248 <td valign="top">
240 <td colspan="2"><span class="module-name" dir="ltr" 249 <span dir="ltr"
241 jscontent="name">NAME</span> 250 jsvalues=".innerHTML:description" class="nowrap"></span>
242 <span dir="ltr" 251 <div jsdisplay="status == 2 || status == 3"
243 jsdisplay="type_description.length > 0" 252 class="extra-info-text"><br>
Nico 2010/11/29 22:02:34 same here
244 >(<span dir="ltr" 253 <span jsdisplay="status == 2"
245 jscontent="type_description">MODULE_TYPE</ span 254 i18n-content="moduleSuspectedBad"
246 >)</span> 255 class="suspected-bad">SUSPECTED_BAD</span>
247 </td> 256 <span jsdisplay="status == 3"
248 </tr> 257 i18n-content="moduleConfirmedBad"
249 <tr> 258 class="confirmed-bad">CONFIRMED_BAD</span>
250 <td width="75"><span i18n-content="headerSoftware" /></td> 259 <a jsdisplay="help_url.length &gt; 0"
251 <td><span dir="ltr" jsvalues=".innerHTML:description"></span> 260 jsvalues=".href:help_url"><span
252 <span dir="ltr" jsdisplay="version.length > 0"> - </span> 261 i18n-content="helpCenterLink">HELP_CENTER</span></a>
253 <span dir="ltr" jscontent="version">VERSION</span></td> 262 <span jsdisplay="possibleResolution.length &gt; 0"><br>
Nico 2010/11/29 22:02:34 this can probably be done with clear:left (or righ
254 </tr> 263 <span jscontent="possibleResolution"
255 <tr jsdisplay="digital_signer.length > 0"> 264 >POSSIBLE_RESOLUTION</span>
256 <td><span i18n-content="headerSignedBy" /></td> 265 </span>
257 <td><span dir="ltr" jscontent="digital_signer">SIGNER</span></td> 266 </div>
258 </tr> 267 </td>
259 <tr> 268 <td valign="top"><span dir="ltr" jscontent="digital_signer"
260 <td><span i18n-content="headerLocation" /></td> 269 class="nowrap">SIGNER</span></td>
261 <td><span dir="ltr" 270 <td valign="top"><span dir="ltr" jscontent="version"
262 jscontent="location">LOCATION</span><span 271 class="nowrap">VERSION</span></td>
263 dir="ltr" jscontent="name">NAME</span></td> 272 <td valign="top">
264 </tr> 273 <span class="nowrap">
265 <tr jsdisplay="status == 2 || status == 3"> 274 <span dir="ltr" jscontent="location">LOCATION</span><strong
266 <td><span i18n-content="headerWarning" /></td> 275 ><span dir="ltr" jscontent="name">NAME</span></strong>
267 <td><span jsdisplay="status == 2" 276 <span dir="ltr"
268 i18n-content="moduleSuspectedBad" 277 jsdisplay="type_description.length &gt; 0"
269 class="suspected-bad">SUSPECTED_BAD</span> 278 >(<span dir="ltr"
270 <span jsdisplay="status == 3" 279 jscontent="type_description">MODULE_TYPE</span
271 i18n-content="moduleConfirmedBad" 280 >)</span>
272 class="confirmed-bad">CONFIRMED_BAD</span> 281 </span>
273 <a jsdisplay="help_url.length > 0" 282 </td>
274 jsvalues=".href:help_url"><span 283 </tr>
275 i18n-content="helpCenterLink">HELP_CENTER</span></a>
276 </td>
277 </tr>
278 <tr jsdisplay="possibleResolution.length > 0">
279 <td><span i18n-content="headerHelpTip" /></td>
280 <td><span
281 jscontent="possibleResolution">POSSIBLE_RESOLUTION</span></td>
282 </tr>
283 </table>
284
285 </td>
286 </tr>
287 </table> 284 </table>
288 </div> 285 </td>
286 </tr>
287 </table>
289 </div> 288 </div>
290 </div> 289 </div>
291 </div> 290 </div>
292 </div> 291 </div>
293 </body> 292 </body>
294 </html> 293 </html>
OLDNEW
« no previous file with comments | « chrome/browser/enumerate_modules_model_win.cc ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698