Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(341)

Unified Diff: webkit/browser/fileapi/file_system_backend.h

Issue 527773003: Add GetURLForBrowserTab method to the external file system backend. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Fix comment. Created 6 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/browser/chromeos/fileapi/mtp_file_system_backend_delegate.cc ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: webkit/browser/fileapi/file_system_backend.h
diff --git a/webkit/browser/fileapi/file_system_backend.h b/webkit/browser/fileapi/file_system_backend.h
index b71c8cab06d7fce114b06a3ade098dff8084f165..1093e0fd4aa561a0b181f6c341147b16c2a725c9 100644
--- a/webkit/browser/fileapi/file_system_backend.h
+++ b/webkit/browser/fileapi/file_system_backend.h
@@ -157,6 +157,11 @@ class ExternalFileSystemBackend : public FileSystemBackend {
// path is not exposed by this provider.
virtual bool GetVirtualPath(const base::FilePath& file_system_path,
base::FilePath* virtual_path) = 0;
+ // Gets an alternative URL for browser tab. e.g. Google Drive URL for hosted
mtomasz 2014/09/03 09:44:42 nit: "alternative" sounds strange. It means that e
hirono 2014/09/03 13:02:45 I chose "redirect" URL.
+ // documents. Returns empty URL if the entry does not have an alternatvie URL.
+ virtual void GetURLForBrowserTab(
+ const storage::FileSystemURL& url,
+ const base::Callback<void(const GURL& url)>& callback) = 0;
mtomasz 2014/09/03 09:44:42 nit: How about typedefing this callback like in #4
hirono 2014/09/03 13:02:45 Done.
};
} // namespace storage
« no previous file with comments | « chrome/browser/chromeos/fileapi/mtp_file_system_backend_delegate.cc ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698