Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(448)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 52773004: Move Glyph related classes to platform/fonts (Closed)

Created:
7 years, 1 month ago by rwlbuis
Modified:
7 years, 1 month ago
CC:
blink-reviews, eae+blinkwatch, apavlov+blink_chromium.org, pdr, aandrey+blink_chromium.org, jamesr, caseq+blink_chromium.org, bemjb+rendering_chromium.org, dsinclair, yurys+blink_chromium.org, danakj, dglazkov+blink, Rik, jchaffraix+rendering, devtools-reviews_chromium.org, pdr., loislo+blink_chromium.org, zoltan1, lushnikov+blink_chromium.org, eustas+blink_chromium.org, paulirish+reviews_chromium.org, darktears, alph+blink_chromium.org, leviw+renderwatch, vsevik+blink_chromium.org, pfeldman+blink_chromium.org, f(malita), Stephen Chennney
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Visibility:
Public.

Description

Move Glyph related classes to platform/fonts BUG=297477 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=160982

Patch Set 1 #

Total comments: 2

Patch Set 2 : Add more items to the gypi file #

Patch Set 3 : Merge gypi #

Unified diffs Side-by-side diffs Delta from patch set Stats (+25 lines, -1002 lines) Patch
M Source/core/core.gypi View 1 2 2 chunks +0 lines, -2 lines 0 comments Download
M Source/core/css/CSSFontFaceSrcValue.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/fetch/FontResource.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/inspector/InspectorCSSAgent.cpp View 2 chunks +1 line, -1 line 0 comments Download
D Source/core/platform/graphics/AlternateFontFamily.h View 1 chunk +0 lines, -128 lines 0 comments Download
M Source/core/platform/graphics/FontCache.cpp View 1 chunk +1 line, -1 line 0 comments Download
D Source/core/platform/graphics/FontCustomPlatformData.h View 1 chunk +0 lines, -88 lines 0 comments Download
M Source/core/platform/graphics/FontFallbackList.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/platform/graphics/FontFastPath.cpp View 1 chunk +1 line, -1 line 0 comments Download
D Source/core/platform/graphics/GlyphBuffer.h View 1 chunk +0 lines, -149 lines 0 comments Download
D Source/core/platform/graphics/GlyphMetricsMap.h View 1 chunk +0 lines, -130 lines 0 comments Download
D Source/core/platform/graphics/GlyphPage.h View 1 chunk +0 lines, -204 lines 0 comments Download
M Source/core/platform/graphics/GlyphPageTreeNode.h View 1 chunk +1 line, -1 line 0 comments Download
D Source/core/platform/graphics/Latin1TextIterator.h View 1 chunk +0 lines, -67 lines 0 comments Download
M Source/core/platform/graphics/SimpleFontData.h View 1 chunk +2 lines, -2 lines 0 comments Download
D Source/core/platform/graphics/WidthCache.h View 1 chunk +0 lines, -216 lines 0 comments Download
M Source/core/platform/graphics/WidthIterator.cpp View 1 chunk +2 lines, -2 lines 0 comments Download
M Source/core/platform/graphics/chromium/FontChromiumWin.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/platform/graphics/harfbuzz/FontHarfBuzz.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/platform/graphics/harfbuzz/HarfBuzzFaceSkia.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/platform/graphics/harfbuzz/HarfBuzzShaper.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/platform/graphics/mac/ComplexTextController.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/platform/graphics/mac/FontComplexTextMac.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/platform/graphics/mac/FontCustomPlatformDataMac.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/platform/graphics/mac/FontMac.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/platform/graphics/opentype/OpenTypeVerticalData.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/platform/graphics/skia/FontCacheSkia.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/platform/graphics/skia/FontCustomPlatformDataSkia.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/platform/graphics/win/FontCustomPlatformDataWin.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/rendering/svg/SVGTextRunRenderingContext.cpp View 2 chunks +1 line, -1 line 0 comments Download
M Source/core/svg/SVGGlyphMap.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/platform/blink_platform.gypi View 1 2 2 chunks +7 lines, -0 lines 0 comments Download
A + Source/platform/fonts/AlternateFontFamily.h View 0 chunks +-1 lines, --1 lines 0 comments Download
A + Source/platform/fonts/FontCustomPlatformData.h View 0 chunks +-1 lines, --1 lines 0 comments Download
A + Source/platform/fonts/GlyphBuffer.h View 0 chunks +-1 lines, --1 lines 0 comments Download
A + Source/platform/fonts/GlyphMetricsMap.h View 0 chunks +-1 lines, --1 lines 0 comments Download
A + Source/platform/fonts/GlyphPage.h View 0 chunks +-1 lines, --1 lines 0 comments Download
A + Source/platform/fonts/Latin1TextIterator.h View 0 chunks +-1 lines, --1 lines 0 comments Download
A + Source/platform/fonts/WidthCache.h View 0 chunks +-1 lines, --1 lines 0 comments Download

Messages

Total messages: 7 (0 generated)
rwlbuis
I discovered these Glyph/Font classes are not dependent on Font.h or GraphicsContext.h, so they can ...
7 years, 1 month ago (2013-10-30 18:44:33 UTC) #1
Stephen Chennney
You need to add some more to the gypi file. Otherwise LGTM. https://codereview.chromium.org/52773004/diff/1/Source/platform/blink_platform.gypi File Source/platform/blink_platform.gypi ...
7 years, 1 month ago (2013-10-30 19:03:13 UTC) #2
rwlbuis
https://codereview.chromium.org/52773004/diff/1/Source/platform/blink_platform.gypi File Source/platform/blink_platform.gypi (right): https://codereview.chromium.org/52773004/diff/1/Source/platform/blink_platform.gypi#newcode238 Source/platform/blink_platform.gypi:238: 'fonts/AlternateFontFamily.h', On 2013/10/30 19:03:14, Stephen Chenney wrote: > Add ...
7 years, 1 month ago (2013-10-30 19:28:35 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/rob.buis@samsung.com/52773004/70001
7 years, 1 month ago (2013-10-30 19:33:04 UTC) #4
commit-bot: I haz the power
Retried try job too often on win_layout for step(s) webkit_lint http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=win_layout&number=13706
7 years, 1 month ago (2013-10-30 21:01:09 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/rob.buis@samsung.com/52773004/210001
7 years, 1 month ago (2013-10-30 21:25:08 UTC) #6
commit-bot: I haz the power
7 years, 1 month ago (2013-10-30 22:58:35 UTC) #7
Message was sent while issue was closed. 
Change committed as 160982

Powered by Google App Engine
This is Rietveld 408576698