Issue 52773003: Fix PNaCl build of zlib on buildbot.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 52773003: Fix PNaCl build of zlib on buildbot. (Closed)

Created:
7 years, 1 month ago by Sam Clegg

Modified:
7 years, 1 month ago

Reviewers:
jvoung (off chromium)

CC:
native-client-reviews_googlegroups.com

Base URL:
https://naclports.googlecode.com/svn/trunk/src

Visibility:
Public.

More Reviews

Description

Fix PNaCl build of zlib on buildbot. The PNaCl build of zlib is currently failing on the bot due to a combination of libz.so.1 not being cleaned after a glibc build and LD_LIBRARY_PATH being exported in the test phases to include ".". This change fixes both the issues. R=jvoung@chromium.org Committed: https://code.google.com/p/naclports/source/detail?r=951

Patch Set 1 #

Total comments: 2

Created: 7 years, 1 month ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+4 lines, -2 lines)			Patch
	M	libraries/zlib/build.sh	View		4 chunks	+4 lines, -2 lines	2 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

jvoung (off chromium)

one question, otherwise LGTM https://codereview.chromium.org/52773003/diff/1/libraries/zlib/build.sh File libraries/zlib/build.sh (right): https://codereview.chromium.org/52773003/diff/1/libraries/zlib/build.sh#newcode92 libraries/zlib/build.sh:92: PatchStep Is this part of ...

7 years, 1 month ago (2013-10-30 18:26:51 UTC) #2

Sam Clegg

https://codereview.chromium.org/52773003/diff/1/libraries/zlib/build.sh File libraries/zlib/build.sh (right): https://codereview.chromium.org/52773003/diff/1/libraries/zlib/build.sh#newcode92 libraries/zlib/build.sh:92: PatchStep On 2013/10/30 18:26:52, jvoung (cr) wrote: > Is ...

7 years, 1 month ago (2013-10-30 18:28:12 UTC) #3

Sam Clegg

7 years, 1 month ago (2013-10-30 18:28:26 UTC) #4

Message was sent while issue was closed.

Committed patchset #1 manually as r951 (presubmit successful).

Expand Messages | Collapse Messages