Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(225)

Issue 527723002: [fsp] Cleanup IDL. (Closed)

Created:
6 years, 3 months ago by mtomasz
Modified:
6 years, 3 months ago
Reviewers:
benwells
CC:
chromium-reviews, chromium-apps-reviews_chromium.org, extensions-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

[fsp] Cleanup IDL. This CL adds descriptions to dictionaries. TEST=Tested manually with a test server. BUG=248427 Committed: https://crrev.com/5e5d8cab910cf1f3e4b4101a4c8fe279b9db823a Cr-Commit-Position: refs/heads/master@{#293121}

Patch Set 1 #

Total comments: 27

Patch Set 2 : Fixes. #

Patch Set 3 : Rebased. #

Patch Set 4 : Rebased. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+110 lines, -9 lines) Patch
M chrome/common/extensions/api/file_system_provider.idl View 1 2 3 10 chunks +110 lines, -9 lines 0 comments Download

Messages

Total messages: 17 (4 generated)
mtomasz
@benwells: PTAL. Besides just review, could you verify in depth English correctness? Since it's going ...
6 years, 3 months ago (2014-09-01 05:20:51 UTC) #2
benwells
https://codereview.chromium.org/527723002/diff/1/chrome/common/extensions/api/file_system_provider.idl File chrome/common/extensions/api/file_system_provider.idl (right): https://codereview.chromium.org/527723002/diff/1/chrome/common/extensions/api/file_system_provider.idl#newcode57 chrome/common/extensions/api/file_system_provider.idl:57: // An identifier of the file system. s/An/The/ https://codereview.chromium.org/527723002/diff/1/chrome/common/extensions/api/file_system_provider.idl#newcode60 ...
6 years, 3 months ago (2014-09-03 01:19:39 UTC) #3
mtomasz
https://codereview.chromium.org/527723002/diff/1/chrome/common/extensions/api/file_system_provider.idl File chrome/common/extensions/api/file_system_provider.idl (right): https://codereview.chromium.org/527723002/diff/1/chrome/common/extensions/api/file_system_provider.idl#newcode45 chrome/common/extensions/api/file_system_provider.idl:45: // File size in bytes. Should it be "The ...
6 years, 3 months ago (2014-09-03 04:01:19 UTC) #4
mtomasz
On 2014/09/03 04:01:19, mtomasz wrote: > https://codereview.chromium.org/527723002/diff/1/chrome/common/extensions/api/file_system_provider.idl > File chrome/common/extensions/api/file_system_provider.idl (right): > > https://codereview.chromium.org/527723002/diff/1/chrome/common/extensions/api/file_system_provider.idl#newcode45 > ...
6 years, 3 months ago (2014-09-03 04:01:42 UTC) #5
benwells
lgtm https://codereview.chromium.org/527723002/diff/1/chrome/common/extensions/api/file_system_provider.idl File chrome/common/extensions/api/file_system_provider.idl (right): https://codereview.chromium.org/527723002/diff/1/chrome/common/extensions/api/file_system_provider.idl#newcode123 chrome/common/extensions/api/file_system_provider.idl:123: // A request ID which will be used ...
6 years, 3 months ago (2014-09-03 05:22:17 UTC) #6
mtomasz
6 years, 3 months ago (2014-09-03 06:55:03 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/mtomasz@chromium.org/527723002/40001
6 years, 3 months ago (2014-09-03 06:55:50 UTC) #9
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). The failing builders are: linux_chromium_chromeos_rel_swarming on tryserver.chromium.linux ...
6 years, 3 months ago (2014-09-03 07:55:56 UTC) #10
commit-bot: I haz the power
Try jobs failed on following builders: linux_chromium_chromeos_rel_swarming on tryserver.chromium.linux (http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_chromeos_rel_swarming/builds/10317)
6 years, 3 months ago (2014-09-03 08:00:24 UTC) #12
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/mtomasz@chromium.org/527723002/60001
6 years, 3 months ago (2014-09-03 09:39:37 UTC) #14
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). The failing builders are: android_dbg_tests_recipe on tryserver.chromium.linux ...
6 years, 3 months ago (2014-09-03 10:36:40 UTC) #15
commit-bot: I haz the power
Committed patchset #4 (id:60001) as 753daa1637c3f965c7a8897fea1d1f29d1f113ee
6 years, 3 months ago (2014-09-03 11:34:33 UTC) #16
commit-bot: I haz the power
6 years, 3 months ago (2014-09-10 03:25:17 UTC) #17
Message was sent while issue was closed.
Patchset 4 (id:??) landed as
https://crrev.com/5e5d8cab910cf1f3e4b4101a4c8fe279b9db823a
Cr-Commit-Position: refs/heads/master@{#293121}

Powered by Google App Engine
This is Rietveld 408576698