Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(156)

Issue 527703002: [ServiceWorker] Introduce skipServiceWorker flag to blink::WebURLRequest and blink::ResourceRequest (Closed)

Created:
6 years, 3 months ago by horo
Modified:
6 years, 3 months ago
Reviewers:
tkent, nhiroki
CC:
blink-reviews, jamesr, dglazkov+blink, Nate Chapin, gavinp+loader_chromium.org, abarth-chromium
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Project:
blink
Visibility:
Public.

Description

[ServiceWorker] Introduce skipServiceWorker flag to blink::WebURLRequest and blink::ResourceRequest If the request is a force refresh (shift+refresh) the request should not be handled by the ServiceWorker. https://slightlyoff.github.io/ServiceWorker/spec/service_worker/#navigator-service-worker-controller Currently we are checking LOAD_BYPASS_CACHE flag of net::URLRequest in ServiceWorkerControlleeRequestHandler::MaybeCreateJob(). But this flag is set not only when shift+refresh but also when devtool's "Disable cache" is checked. To distinguish them, I want to add skipServiceWorker flag to blink::WebURLRequest and blink::ResourceRequest and SKIP_SERVICE_WORKER flag to net::URLRequest. This is blink side patch. Chromium side patch is this. https://codereview.chromium.org/527713002/ BUG=402093 TEST=none Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=181155

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+21 lines, -0 lines) Patch
M Source/core/loader/FrameLoader.cpp View 1 chunk +1 line, -0 lines 0 comments Download
M Source/platform/exported/WebURLRequest.cpp View 1 chunk +10 lines, -0 lines 0 comments Download
M Source/platform/network/ResourceRequest.h View 2 chunks +5 lines, -0 lines 0 comments Download
M Source/platform/network/ResourceRequest.cpp View 1 chunk +1 line, -0 lines 0 comments Download
M public/platform/WebURLRequest.h View 1 chunk +4 lines, -0 lines 0 comments Download

Messages

Total messages: 11 (3 generated)
horo
nhiroki@ Could you please review this?
6 years, 3 months ago (2014-09-01 05:27:23 UTC) #1
horo
nhiroki@ Could you please review this?
6 years, 3 months ago (2014-09-01 05:28:26 UTC) #3
nhiroki
LGTM. Can you fill in the TEST= line?
6 years, 3 months ago (2014-09-01 05:45:35 UTC) #4
horo
On 2014/09/01 05:45:35, nhiroki wrote: > LGTM. Can you fill in the TEST= line? Thank ...
6 years, 3 months ago (2014-09-01 06:17:37 UTC) #5
horo
tkent@ Could you please review this cl?
6 years, 3 months ago (2014-09-01 06:25:35 UTC) #7
tkent
lgtm
6 years, 3 months ago (2014-09-01 07:21:44 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/horo@chromium.org/527703002/1
6 years, 3 months ago (2014-09-01 07:26:39 UTC) #10
commit-bot: I haz the power
6 years, 3 months ago (2014-09-01 07:30:48 UTC) #11
Message was sent while issue was closed.
Committed patchset #1 (id:1) as 181155

Powered by Google App Engine
This is Rietveld 408576698