Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(312)

Issue 527693002: Move AppWindowContentsImpl to extensions (Closed)

Created:
6 years, 3 months ago by hashimoto
Modified:
6 years, 3 months ago
Reviewers:
benwells, Daniel Erat
CC:
chromium-reviews, extensions-reviews_chromium.org, sadrul, tfarina, chromium-apps-reviews_chromium.org, kalyank, ben+ash_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Move AppWindowContentsImpl to extensions Remove unneeded include from app_window_contents.cc Move app_window_contents.{cc,h} to extensions/browser/app_window Change the namespace from apps to extensions. BUG=403726 TBR=derat@chromium.org for include&namespace fix Committed: https://crrev.com/5c34ceb43fe742c953e76f73052e9119705a71a6 Cr-Commit-Position: refs/heads/master@{#293094}

Patch Set 1 #

Patch Set 2 : rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+33 lines, -265 lines) Patch
M apps/BUILD.gn View 1 chunk +0 lines, -2 lines 0 comments Download
D apps/app_window_contents.h View 1 chunk +0 lines, -72 lines 0 comments Download
D apps/app_window_contents.cc View 1 chunk +0 lines, -145 lines 0 comments Download
M apps/apps.gypi View 1 chunk +0 lines, -2 lines 0 comments Download
M chrome/browser/apps/app_browsertest_util.cc View 3 chunks +2 lines, -3 lines 0 comments Download
M chrome/browser/extensions/api/app_window/app_window_api.cc View 3 chunks +2 lines, -3 lines 0 comments Download
M chrome/browser/power/process_power_collector_unittest.cc View 2 chunks +1 line, -1 line 0 comments Download
M chrome/browser/ui/ash/launcher/chrome_launcher_controller_unittest.cc View 3 chunks +2 lines, -2 lines 0 comments Download
M extensions/browser/BUILD.gn View 1 1 chunk +2 lines, -0 lines 0 comments Download
A + extensions/browser/app_window/app_window_contents.h View 3 chunks +15 lines, -22 lines 0 comments Download
A + extensions/browser/app_window/app_window_contents.cc View 7 chunks +7 lines, -13 lines 0 comments Download
M extensions/extensions.gyp View 1 chunk +2 lines, -0 lines 0 comments Download

Messages

Total messages: 11 (3 generated)
hashimoto
6 years, 3 months ago (2014-09-01 05:03:18 UTC) #2
benwells
lgtm
6 years, 3 months ago (2014-09-03 01:09:29 UTC) #3
hashimoto
TBRing derat@chromium.org for include & namespace fix in chrome/browser/power/process_power_collector_unittest.cc and chrome/browser/ui/ash/launcher/chrome_launcher_controller_unittest.cc
6 years, 3 months ago (2014-09-03 04:05:59 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/hashimoto@chromium.org/527693002/20001
6 years, 3 months ago (2014-09-03 04:34:34 UTC) #7
Daniel Erat
lgtm
6 years, 3 months ago (2014-09-03 05:11:18 UTC) #8
Daniel Erat
lgtm lgtm
6 years, 3 months ago (2014-09-03 05:11:19 UTC) #9
commit-bot: I haz the power
Committed patchset #2 (id:20001) as 36637ba97cad05364d348211edac5452075991e7
6 years, 3 months ago (2014-09-03 07:38:13 UTC) #10
commit-bot: I haz the power
6 years, 3 months ago (2014-09-10 03:24:18 UTC) #11
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/5c34ceb43fe742c953e76f73052e9119705a71a6
Cr-Commit-Position: refs/heads/master@{#293094}

Powered by Google App Engine
This is Rietveld 408576698