Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(546)

Issue 527663002: [fsp] Enable the File System Provider API for extensions. (Closed)

Created:
6 years, 3 months ago by mtomasz
Modified:
6 years, 3 months ago
CC:
chromium-reviews, extensions-reviews_chromium.org, nkostylev+watch_chromium.org, oshima+watch_chromium.org, chromium-apps-reviews_chromium.org, stevenjb+watch_chromium.org, davemoore+watch_chromium.org, not at google - send to devlin
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

[fsp] Enable the File System Provider API for extensions. Previously, only apps were allowed to use this api, however most clients will be actually written as extensions. TEST=browser_tests: *FileSystemProvider*Extension* BUG=409487 Committed: https://crrev.com/c171298eff20e7e8efe2e9fd21b9466bfffcb71c Cr-Commit-Position: refs/heads/master@{#293100}

Patch Set 1 #

Patch Set 2 : Rebased. #

Messages

Total messages: 18 (8 generated)
mtomasz
@benwells: PTAL. Thanks. @kalman: FYI.
6 years, 3 months ago (2014-09-01 02:14:03 UTC) #3
not at google - send to devlin
Features file lgtm.
6 years, 3 months ago (2014-09-01 15:11:37 UTC) #5
benwells
lgtm
6 years, 3 months ago (2014-09-03 01:00:47 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/mtomasz@chromium.org/527663002/1
6 years, 3 months ago (2014-09-03 03:09:33 UTC) #10
commit-bot: I haz the power
Failed to apply patch for chrome/common/extensions/api/_permission_features.json: While running git apply --index -p1; error: patch failed: ...
6 years, 3 months ago (2014-09-03 05:37:29 UTC) #12
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/mtomasz@chromium.org/527663002/20001
6 years, 3 months ago (2014-09-03 06:43:20 UTC) #14
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). The failing builders are: android_dbg_tests_recipe on tryserver.chromium.linux ...
6 years, 3 months ago (2014-09-03 07:53:14 UTC) #15
commit-bot: I haz the power
Committed patchset #2 (id:20001) as 4acb869459901c6fa627473bb15b8a0f6190cc11
6 years, 3 months ago (2014-09-03 08:51:45 UTC) #16
Andre
A revert of this CL (patchset #2 id:20001) has been created in https://codereview.chromium.org/537603002/ by andresantoso@chromium.org. ...
6 years, 3 months ago (2014-09-03 16:19:11 UTC) #17
commit-bot: I haz the power
6 years, 3 months ago (2014-09-10 03:24:30 UTC) #18
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/c171298eff20e7e8efe2e9fd21b9466bfffcb71c
Cr-Commit-Position: refs/heads/master@{#293100}

Powered by Google App Engine
This is Rietveld 408576698